RESOLVED FIXED 177311
Make StringBuilder movable 
https://bugs.webkit.org/show_bug.cgi?id=177311
Summary Make StringBuilder movable
Alex Christensen
Reported 2017-09-21 10:51:53 PDT
Make StringBuilder movable
Attachments
Patch (1.21 KB, patch)
2017-09-21 10:52 PDT, Alex Christensen 		cdumez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2017-09-21 10:52:03 PDT
Created attachment 321449 [details] Patch
Chris Dumez
Comment 2 2017-09-21 10:55:42 PDT
Comment on attachment 321449 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=321449&action=review > Source/WTF/wtf/text/StringBuilder.h:48 > + StringBuilder(StringBuilder&&) = default; I believe StringBuilder is movable already. Why wouldn't it be? See rules at http://en.cppreference.com/w/cpp/language/move_constructor ("Implicitly-declared move constructor" section).
Alex Christensen
Comment 3 2017-09-21 10:57:05 PDT
I'm trying to put it as a value in a HashMap, which requires this. HashMap uses a lot of = std::forward<T>(value).
Alex Christensen
Comment 4 2017-09-21 11:01:27 PDT
In this case there is a user-defined copy constructor and operator= from WTF_MAKE_NONCOPYABLE. These need to be explicit.
Alex Christensen
Comment 5 2017-09-21 13:45:11 PDT
http://trac.webkit.org/r222346
Radar WebKit Bug Importer
Comment 6 2017-09-27 12:22:37 PDT
<rdar://problem/34693155>
Note You need to log in before you can comment on or make changes to this bug.