Bug 177306 – REGRESSION(r221465) WKWebViews without WebGL delegate callbacks crash when WebGL contexts are created

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alex Christensen]

REGRESSION(r221465) WKWebViews without WebGL delegate callbacks crash when WebGL contexts are created

[Alex Christensen]

Created attachment 321438 [details]
Patch

[Chris Dumez]

Comment on attachment 321438 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321438&action=review

r=me

> Source/WebKit/UIProcess/Cocoa/NavigationState.mm:311
> +        return completionHandler(WebGLAllowCreation);

I seem to remember Darin not liking this pattern and preferring doing this on 2 lines.

> Source/WebKit/UIProcess/Cocoa/NavigationState.mm:326
> +        return completionHandler(WebGLAllowCreation);

ditto.

[Alex Christensen]

http://trac.webkit.org/r222322

[Darin Adler]

Comment on attachment 321438 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321438&action=review

>> Source/WebKit/UIProcess/Cocoa/NavigationState.mm:311
>> +        return completionHandler(WebGLAllowCreation);
> 
> I seem to remember Darin not liking this pattern and preferring doing this on 2 lines.

I think that for the WebKit project style guide we have said we should do it on two lines. Maybe should write that out explicitly.

But, to be clear, I personally am OK with this pattern, and might adopt it as the style for my own programming outside the WebKit project.

As I understand it, this feature was originally added to C++ make template programming easier, rather than because the people proposing it thought it was elegant for non-template cases like this one.

[Radar WebKit Bug Importer]

<rdar://problem/34693051>