Bug 177290 – JSC should use unified sources for platform specific files.

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Keith Miller]

...

[Keith Miller]

Created attachment 321403 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 321403 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321403&action=review

> Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:3312
> +		536B31981F735E5C0037FC33 /* UnifiedSource1.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = UnifiedSource1.mm; sourceTree = "<group>"; };
> +		536B31991F735E5D0037FC33 /* UnifiedSource135.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = UnifiedSource135.cpp; sourceTree = "<group>"; };

Sorting these would be epic.

> Source/JavaScriptCore/PlatformGTK.cmake:2
> +n

Hmmm.

[Keith Miller]

Created attachment 321404 [details]
Patch

[Keith Miller]

Created attachment 321405 [details]
Patch

[Keith Miller]

(In reply to Joseph Pecoraro from comment #2)
> Comment on attachment 321403 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=321403&action=review
> 
> > Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:3312
> > +		536B31981F735E5C0037FC33 /* UnifiedSource1.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = UnifiedSource1.mm; sourceTree = "<group>"; };
> > +		536B31991F735E5D0037FC33 /* UnifiedSource135.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = UnifiedSource135.cpp; sourceTree = "<group>"; };
> 
> Sorting these would be epic.

Can I do that in another patch?

[Keith Miller]

Created attachment 321406 [details]
Patch

[Matt Baker]

Comment on attachment 321406 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321406&action=review

Pedantic nits.

> Source/WTF/ChangeLog:12
> +        performance changes when files are added to an unrelated platform.

Nit: this wording is awkward. Two things:

1) "...bundler script now can..." should read "...bundler script can now..."
2) This sentence: "We avoid that changing one platform's sources doesn't break anothers."

> Source/WTF/ChangeLog:14
> +        Remove old stale reference to generate-unified-source-bundles.rb

old or stale. Pick one.

[Keith Miller]

Comment on attachment 321406 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321406&action=review

>> Source/WTF/ChangeLog:12
>> +        performance changes when files are added to an unrelated platform.
> 
> Nit: this wording is awkward. Two things:
> 
> 1) "...bundler script now can..." should read "...bundler script can now..."
> 2) This sentence: "We avoid that changing one platform's sources doesn't break anothers."

Yeah, that's pretty poor wording... Fixed.

>> Source/WTF/ChangeLog:14
>> +        Remove old stale reference to generate-unified-source-bundles.rb
> 
> old or stale. Pick one.

stale it is!

[Keith Miller]

Created attachment 321428 [details]
Patch

[Michael Saboff]

Comment on attachment 321428 [details]
Patch

r=me

[Keith Miller]

Committed r222327: <http://trac.webkit.org/changeset/222327>

[Keith Miller]

*** Bug 177112 has been marked as a duplicate of this bug. ***

[Radar WebKit Bug Importer]

<rdar://problem/34693118>