Add long press and drag test
Created attachment 321402 [details] Patch
Comment on attachment 321402 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=321402&action=review > LayoutTests/fast/events/touch/ios/long-press-then-drag-to-select-text.html:36 > + output += 'FAIL: failed to select correct word as a result of a drag after long press. Incorrect selection: ' + document.getSelection().toString(); Odd spacing here. Tabs? > LayoutTests/fast/events/touch/ios/resources/basic-gestures.js:64 > +function longPressAtPointNoLift(X, Y) The "NoLift" is awkward. Maybe pressAndHoldAtPoint? > LayoutTests/fast/events/touch/ios/resources/basic-gestures.js:70 > + { Canonical style would be to outdent opening and closing braces. > LayoutTests/fast/events/touch/ios/resources/basic-gestures.js:105 > + uiController.sendEventStream(JSON.stringify(eventStream), function() {}); > + uiController.uiScriptComplete(); These should be indented. > LayoutTests/fast/events/touch/ios/resources/basic-gestures.js:151 > + uiController.sendEventStream(JSON.stringify(eventStream), function() {}); > + uiController.uiScriptComplete(); Ditto.
Comment on attachment 321402 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=321402&action=review > LayoutTests/fast/events/touch/ios/resources/basic-gestures.js:11 > +// should switch to this method in all tests, as it is more clear what is being done. Comments should start with a capital and be a complete sentence :P (also, is this just a find-and-replace? Might be worth it to just do it? Or not, either way) >> LayoutTests/fast/events/touch/ios/resources/basic-gestures.js:64 >> +function longPressAtPointNoLift(X, Y) > > The "NoLift" is awkward. Maybe pressAndHoldAtPoint? Agreed.
https://trac.webkit.org/r222337
<rdar://problem/34693068>
Reverted r222337 for reason: This test is failing on iOS. Committed r222587: <http://trac.webkit.org/changeset/222587>
Created attachment 322485 [details] Patch
Comment on attachment 322485 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322485&action=review > LayoutTests/fast/events/touch/ios/long-press-then-drag-to-select-text.html:24 > + var dragY = secondTargetRect.y+secondTargetRect.height / 2; Spaces around binary operators! (i.e. the +s) > LayoutTests/fast/events/touch/ios/resources/basic-gestures.js:11 > +function longPressAtPointNoLift(X, Y) I liked pressAndHoldAtPoint better than longPressAtPointNoLift :P > LayoutTests/fast/events/touch/ios/resources/basic-gestures.js:118 > + { I think the formatting turned a bit Xcode-y here...can we make this consistent with the function above?
Somehow this got left in a weird state. https://trac.webkit.org/changeset/222813/webkit