Bug 17725 – XPath should be case insensitive for HTML

• Status: RESOLVED
• Resolution: FIXED
• Component: XML

[Romuald Brunet]

It is not necessarily a bug (since XML is case sensitive), but I've found that XPath implementation in Safari differs from some other browsers (Firefox and Opera).

For exemple, in a xhtml 1.0 document, retrieving .//IMG won't return anything (either if the tags are uppercase, which is invalid xhtml, or if they are not).
You can check the url for a practical example

Found this bug because I'm used to use uppercase for tags in CSS selectors.

Since this behavior applies in Firefox and Opera, you may choose to change Safari's implementation.

[Alexey Proskuryakov]

I don't see any reason to remain incompatible with other engines in this respect, patch forthcoming.

[Alexey Proskuryakov]

Created attachment 30701 [details]
proposed fix

[Darin Adler]

Comment on attachment 30701 [details]
proposed fix

> +            if (node->nodeType() != Node::ELEMENT_NODE)
> +                return false;

How about isElementNode() instead?

> +            if (node->isHTMLElement() && node->document()->isHTMLDocument()) {
> +                // Paths without namespaces should match HTML elements in HTML documents despite those having an XHTML namespace. Names are compared case-insensitively.
> +                return equalIgnoringCase(static_cast<Element*>(node)->localName(), name) && (namespaceURI.isNull() || namespaceURI == node->namespaceURI());
> +            } else
> +                return static_cast<Element*>(node)->hasLocalName(name) && namespaceURI == node->namespaceURI();

We normally don't do else after return.

r=me

[Alexey Proskuryakov]

Committed <http://trac.webkit.org/changeset/44190>.

(In reply to comment #3)
> How about isElementNode() instead?

Node::ELEMENT_NODE is used elsewhere in this file, it seemed good for consistency.

> We normally don't do else after return.

Fixed.