Move MediaTimeAVFoundation into PAL. This is a blocker to move platform/Clock.
Created attachment 321302 [details]
Comment on attachment 321302 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=321302&action=review
Is this file actually used anymore?
r=me assuming you get EWS happy
(In reply to Myles C. Maxfield from comment #2)
> Comment on attachment 321302 [details]
> View in context:
> > Source/WebCore/Configurations/WebCore.unexp:72
> > +__ZNK3WTF9MediaTime9timeValueEv
> Is this file actually used anymore?
Yes, without it I see the following errors:
ERROR: WebCore has a weak external symbol in it.
ERROR: A weak external symbol is generated when a symbol is defined in multiple compilation units and is also marked as being exported from the library.
ERROR: A common cause of weak external symbols is when an inline function is listed in the linker export file.
ERROR: symbol __ZNK3WTF9MediaTime14hasBeenRoundedEv
ERROR: symbol __ZNK3WTF9MediaTime14hasDoubleValueEv
ERROR: symbol __ZNK3WTF9MediaTime18isNegativeInfiniteEv
ERROR: symbol __ZNK3WTF9MediaTime18isPositiveInfiniteEv
ERROR: symbol __ZNK3WTF9MediaTime7isValidEv
ERROR: symbol __ZNK3WTF9MediaTime9timeScaleEv
ERROR: symbol __ZNK3WTF9MediaTime9timeValueEv
Created attachment 321413 [details]
The new PR also adds CoreMediaSoftLink for PAL, to provide "_CMTimeMake" and "_CMTimeMakeWithSeconds".
Comment on attachment 321413 [details]
Clearing flags on attachment: 321413
Committed r222326: <http://trac.webkit.org/changeset/222326>
All reviewed patches have been landed. Closing bug.