Bug 177220 – Update test262 tests

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Joseph Pecoraro]

Update test262 tests.

1. Update to today's test262
  - includes ES2017 proposals for things we have implemented (Promise.prototype.finally, etc)
  - includes new tests, updated tests, and corrected tests

2. Improve the importer at the same time
  - importer should better detect upstream git repository for test262-Revision.txt
  - importer should update the JSTest/test262 resources from the test262 checkout
  - importer should take no more than a few seconds to write a yaml file from failures, not 20+ minutes
  - update as needed


Notes:

- The test yaml syntax for Exceptions changed. Example:

test/annexB/language/statements/for-in/var-objectbindingpattern-initializer.js
> /*---
> esid: sec-initializers-in-forin-statement-heads
> description: >
>     for-in initializers with ObjectBindingPattern are always prohibited
> negative:
>   phase: early
>   type: SyntaxError
> ---*/

The `negative` block now includes the both a `type` of exception and the `phase` (early or runtime) it should be thrown. I'm going to just keep our YAML the same and just output the type (SyntaxError here) and ignore the phase, since I think that should be covered by the test itself.

> - path: test262/test/annexB/language/statements/for-in/var-objectbindingpattern-initializer.js
>   cmd: runTest262 :normal, "SyntaxError", ["../../../../../harness/assert.js", "../../../../../harness/sta.js"], []

[Joseph Pecoraro]

*** Bug 174944 has been marked as a duplicate of this bug. ***

[Joseph Pecoraro]

Created attachment 321293 [details]
[PATCH] Importer Changes

These are the changes just to the importer. The rest is basically running the importer a few times to update the yaml, get failures, and re-update the yaml.

[Joseph Pecoraro]

Created attachment 321294 [details]
[PATCH] Everything

[Joseph Pecoraro]

>  - path: test262/test/built-ins/ThrowTypeError/unique-per-realm-non-simple.js
> -  cmd: runTest262 :failDueToOutdatedOrBadTest, "NoException", ["../../../harness/assert.js", "../../../harness/sta.js"], []
> +  cmd: runTest262 :fail, "NoException", ["../../../harness/assert.js", "../../../harness/sta.js"], []

This change is interesting. We seem to have thought the test was incorrect, and after updating the test is failing. So this might be a legit failure, or it might still be that this test262 is wrong. I didn't investigate.

[Saam Barati]

Comment on attachment 321293 [details]
[PATCH] Importer Changes

View in context: https://bugs.webkit.org/attachment.cgi?id=321293&action=review

r=me on both

> Tools/ChangeLog:11
> +        - take seconds instead of 20+ minutes to write yaml with --failures

👍🏼

[Yusuke Suzuki]

Comment on attachment 321294 [details]
[PATCH] Everything

r=me

[Joseph Pecoraro]

ERROR from SVN:
A repository hook failed: Commit blocked by pre-commit hook (exit code 1) with output:

    The following files contain tab characters:

        trunk/JSTests/test262/test/built-ins/Date/prototype/setDate/arg-to-number.js
        trunk/JSTests/test262/test/built-ins/Date/prototype/setFullYear/arg-date-to-number.js
        trunk/JSTests/test262/test/built-ins/Date/prototype/setFullYear/arg-month-to-number.js
        trunk/JSTests/test262/test/built-ins/Date/prototype/setFullYear/arg-year-to-number.js
        trunk/JSTests/test262/test/built-ins/Date/prototype/setHours/arg-hour-to-number.js
        trunk/JSTests/test262/test/built-ins/Date/prototype/setHours/arg-min-to-number.js
        trunk/JSTests/test262/test/built-ins/Date/prototype/setHours/arg-ms-to-number.js
        trunk/JSTests/test262/test/built-ins/Date/prototype/setHours/arg-sec-to-number.js
        trunk/JSTests/test262/test/built-ins/Date/prototype/setMilliseconds/arg-to-number.js
        trunk/JSTests/test262/test/built-ins/Date/prototype/setMinutes/arg-min-to-number.js
        trunk/JSTests/test262/test/built-ins/Date/prototype/setMinutes/arg-ms-to-number.js
        trunk/JSTests/test262/test/built-ins/Date/prototype/setMinutes/arg-sec-to-number.js
        trunk/JSTests/test262/test/built-ins/Date/prototype/setMonth/arg-date-to-number.js
        trunk/JSTests/test262/test/built-ins/Date/prototype/setMonth/arg-month-to-number.js
        trunk/JSTests/test262/test/built-ins/Date/prototype/setSeconds/arg-ms-to-number.js
        trunk/JSTests/test262/test/built-ins/Date/prototype/setSeconds/arg-sec-to-number.js
        trunk/JSTests/test262/test/built-ins/Date/prototype/setTime/arg-to-number.js
        trunk/JSTests/test262/test/language/expressions/class/accessor-name-inst-literal-string-char-escape.js
        trunk/JSTests/test262/test/language/expressions/class/accessor-name-static-literal-string-char-escape.js
        trunk/JSTests/test262/test/language/expressions/object/accessor-name-literal-string-char-escape.js
        trunk/JSTests/test262/test/language/statements/class/accessor-name-inst-literal-string-char-escape.js
        trunk/JSTests/test262/test/language/statements/class/accessor-name-static-literal-string-char-escape.js

[Saam Barati]

I think there might be a way to tell SVN that a directory can have tabs. Alexey, do you know how to do this?

[Alexey Proskuryakov]

I know that we can have allow-tabs on files, but I'm not sure if that's recursive. We can check the source of the pre-commit hook to find out for sure.

[Joseph Pecoraro]

Reminder for the future, this is how I set the "allow-tabs" property on files in an SVN checkout:

    svn propset 'allow-tabs' '' JSTests/test262/test/built-ins/Date/prototype/setDate/arg-to-number.js
    svn propset 'allow-tabs' '' JSTests/test262/test/built-ins/Date/prototype/setFullYear/arg-date-to-number.js
    svn propset 'allow-tabs' '' JSTests/test262/test/built-ins/Date/prototype/setFullYear/arg-month-to-number.js
    svn propset 'allow-tabs' '' JSTests/test262/test/built-ins/Date/prototype/setFullYear/arg-year-to-number.js
    ...

[Joseph Pecoraro]

Landed:
<https://trac.webkit.org/r222311> - the bulk!
<https://trac.webkit.org/r222312> - followup fixing some things my SVN land somehow missed

[Radar WebKit Bug Importer]

<rdar://problem/34693214>