Bug 177207 - Drop legacy DOMError type
Summary: Drop legacy DOMError type
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on: 174573 177201
Blocks:
  Show dependency tree / graph
 
Reported: 2017-09-19 15:46 PDT by Chris Dumez
Modified: 2017-09-27 12:23 PDT (History)
7 users (show)

See Also:

Attachments
Patch (23.78 KB, patch)
2017-09-20 14:02 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-09-19 15:46:27 PDT 
Drop legacy DOMError type. It has been removed from the web platform and replaced with Error / DOMException.
Comment 1 Chris Dumez 2017-09-20 14:02:03 PDT 
Created attachment 321363 [details]
Patch
Comment 2 Eric Carlson 2017-09-20 14:27:26 PDT 
Comment on attachment 321363 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321363&action=review

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:30637
> +				E18536841F4E481400FE091B /* WebArchiveResourceFromNSAttributedString.h in Headers */,
> +				E18C35441F71970C00FF632D /* WebArchiveResourceWebResourceHandler.h in Headers */,

Did you mean to include these?

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:34415
> +				E18536851F50906100FE091B /* WebArchiveResourceFromNSAttributedString.mm in Sources */,
> +				E18C35431F71970100FF632D /* WebArchiveResourceWebResourceHandler.mm in Sources */,

Ditto
Comment 3 Chris Dumez 2017-09-20 14:28:59 PDT 
Comment on attachment 321363 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321363&action=review

>> Source/WebCore/WebCore.xcodeproj/project.pbxproj:30637
>> +				E18C35441F71970C00FF632D /* WebArchiveResourceWebResourceHandler.h in Headers */,
> 
> Did you mean to include these?

Xcode re-sorted stuff it looks like. The new location looks more correct so I'll keep it.
Comment 4 WebKit Commit Bot 2017-09-20 14:59:23 PDT 
Comment on attachment 321363 [details]
Patch

Clearing flags on attachment: 321363

Committed r222291: <http://trac.webkit.org/changeset/222291>
Comment 5 WebKit Commit Bot 2017-09-20 14:59:24 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-09-27 12:23:47 PDT 
<rdar://problem/34693189>