WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED WONTFIX
17719
Wx require toDataURL implementations
https://bugs.webkit.org/show_bug.cgi?id=17719
Summary
Wx require toDataURL implementations
Sam Weinig
Reported
2008-03-07 19:13:00 PST
Now that there is a CG implementation of canvas's toDataURL method, we should also implement it for the rest of the ports. For Qt, it should be trivial to us QImageWriter. For the other ports we will probably use at the very least libpng.
Attachments
Entirely untested implementation for Qt
(3.01 KB, patch)
2008-03-07 19:16 PST
,
Sam Weinig
no flags
Details
Formatted Diff
Diff
toDataURL implementation in Cairo
(2.31 KB, patch)
2008-09-15 23:55 PDT
,
Dirk Schulze
no flags
Details
Formatted Diff
Diff
toDataURL implementation in Cairo
(2.33 KB, patch)
2008-09-16 00:09 PDT
,
Dirk Schulze
eric
: review-
Details
Formatted Diff
Diff
toDataURL implementation in Cairo
(2.42 KB, patch)
2008-09-16 01:03 PDT
,
Dirk Schulze
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Sam Weinig
Comment 1
2008-03-07 19:16:59 PST
Created
attachment 19603
[details]
Entirely untested implementation for Qt
Alp Toker
Comment 2
2008-08-11 17:45:00 PDT
For Cairo I think we can get away with using this: cairo_status_t cairo_surface_write_to_png_stream (cairo_surface_t *surface, cairo_write_func_t write_func, void *closure); Mozilla's toDataURL implementation has a full-blown libpng-based encoder we could borrow from if this strategy doesn't work out.
Dirk Schulze
Comment 3
2008-09-15 23:55:01 PDT
Created
attachment 23463
[details]
toDataURL implementation in Cairo This is the implementation of toDataURL in Cairo. It only supports png at the moment. We can try to support more formats later.
Oliver Hunt
Comment 4
2008-09-16 00:04:39 PDT
Comment on
attachment 23463
[details]
toDataURL implementation in Cairo This patch basically looks correct the issue is that you ignore the mimeType argument to toDataURL, and always encode as image/png, but do not report this i think you could get away with: + ASSERT(mimeType == "image/png"); + return String::format("data:image/png;base64,%s", out.data());
Dirk Schulze
Comment 5
2008-09-16 00:09:53 PDT
Created
attachment 23464
[details]
toDataURL implementation in Cairo Fixed the issue with mimetypes.
Eric Seidel (no email)
Comment 6
2008-09-16 00:36:02 PDT
Comment on
attachment 23464
[details]
toDataURL implementation in Cairo Looks good to me. static cairo_status_t writeFunction(void *closure, const unsigned char *data, unsigned int length) 98102 { 99 notImplemented(); 100 return String(); 103 Vector<char> *in = (Vector<char> *) closure; 104 in->append(data, length); 105 return CAIRO_STATUS_SUCCESS; 106 } Has style issues. * placement, and the c-style cast (Vector<char> *) should be a reinterpret_cast<Vector<char>*> instead. Unfortunately you don't yet have commit-bit :( so I'll ask you to post another patch (which I don't need to see, but is needed for someone else to land).
Dirk Schulze
Comment 7
2008-09-16 01:03:54 PDT
Created
attachment 23465
[details]
toDataURL implementation in Cairo fixes the c-style issue.
Oliver Hunt
Comment 8
2008-09-16 01:08:10 PDT
Comment on
attachment 23465
[details]
toDataURL implementation in Cairo looks good, r=me
Alp Toker
Comment 9
2008-09-16 10:01:48 PDT
(In reply to
comment #8
)
> (From update of
attachment 23465
[details]
[edit]) > looks good, r=me >
Cairo patch landed in
r36508
(needed a couple of tweaks to build and not assert in debug builds, and also added the necessary entry in supportedImageMIMETypesForEncoding). Can we close this bug?
Dirk Schulze
Comment 10
2008-09-16 10:21:09 PDT
(In reply to
comment #9
)
> Can we close this bug?
No, the Qt and wx-implementations are missing.
Holger Freyther
Comment 11
2008-09-26 13:07:39 PDT
There is a Qt implementation now. WX is missing.
Darin Adler
Comment 12
2008-10-12 15:12:54 PDT
Comment on
attachment 23465
[details]
toDataURL implementation in Cairo Clearing the review flag since this patch was landed.
Jan Alonzo
Comment 13
2008-10-18 20:29:13 PDT
Changed subject and removed Cairo, Gtk keyword as the patches for these have already landed. Adding in Wx instead.
Martin Robinson
Comment 14
2015-05-07 16:23:54 PDT
The Wx port is no longer in trunk.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug