Bug 177189 - Web Inspector: View should automatically layout when attached to the DOM
Summary: Web Inspector: View should automatically layout when attached to the DOM
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-19 13:45 PDT by Matt Baker
Modified: 2017-09-27 12:21 PDT (History)
5 users (show)

See Also:

Attachments
Patch (6.96 KB, patch)
2017-09-19 13:56 PDT, Matt Baker 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2017-09-19 13:45:29 PDT 
Summary:
A View should automatically layout when it becomes attached to the DOM. Currently a layout has to be scheduled with needsLayout/updateLayout. It shouldn't be possible to have a view attached to the DOM that hasn't had it's initialLayout method called.

This is the behavior that 99% of views will want. If the need arises, we can make it possible to opt out with View constructor options or something.
Comment 1 Matt Baker 2017-09-19 13:56:17 PDT 
Created attachment 321239 [details]
Patch
Comment 2 Devin Rousso 2017-09-22 17:01:13 PDT 
Comment on attachment 321239 [details]
Patch

r=me Nice!
Comment 3 WebKit Commit Bot 2017-09-22 17:27:42 PDT 
Comment on attachment 321239 [details]
Patch

Clearing flags on attachment: 321239

Committed r222416: <http://trac.webkit.org/changeset/222416>
Comment 4 WebKit Commit Bot 2017-09-22 17:27:43 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2017-09-27 12:21:46 PDT 
<rdar://problem/34693128>