Bug 177180 - [CMake] Add ENABLE_WEB_CRYPTO option and make ENABLE_SUBTLE_CRYPTO depend on it.
Summary: [CMake] Add ENABLE_WEB_CRYPTO option and make ENABLE_SUBTLE_CRYPTO depend on it.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Alberto Lopez Perez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-09-19 12:03 PDT by Carlos Alberto Lopez Perez
Modified: 2017-09-27 12:17 PDT (History)
8 users (show)

See Also:


Attachments
Patch (5.48 KB, patch)
2017-09-19 12:18 PDT, Carlos Alberto Lopez Perez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2017-09-19 12:03:47 PDT
On r220445 <https://trac.webkit.org/r172758> the GTK port introduced the public configure option ENABLE_WEB_CRYPTO.

The idea is that users pass ENABLE_WEB_CRYPTO instead of ENABLE_SUBTLE_CRYPTO (subtle crypto is a terrible name)

I think we should use this naming also on the WPE port to enable SUBTLE crypto.

As someone that works on build recipes (Yocto) for WPE and GTK+, I will appreciate to have as much as possible identical config flags for the same features between both ports, to make easier code-sharing of recipe configs


So, if both GTK and WPE are going to use this naming then it make sense to mave also the definition to general CMake config like we do with other options
Comment 1 Carlos Alberto Lopez Perez 2017-09-19 12:18:54 PDT
Created attachment 321231 [details]
Patch
Comment 2 WebKit Commit Bot 2017-09-19 13:42:30 PDT
Comment on attachment 321231 [details]
Patch

Clearing flags on attachment: 321231

Committed r222222: <http://trac.webkit.org/changeset/222222>
Comment 3 WebKit Commit Bot 2017-09-19 13:42:31 PDT
All reviewed patches have been landed.  Closing bug.