Bug 177165 – Update bot configuration for iOS 11

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Ryan Haddad]

Update bot configuration for iOS 11

[Ryan Haddad]

Created attachment 321209 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 321209 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321209&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:53
> +                    { "name": "bot216", "platform": "ios-simulator-11" },
> +                    { "name": "bot217", "platform": "ios-simulator-11" },

Some of the bots here are no longer used. It's probably still right to make the proposed change, but I wanted to point this out to confirm that this is intentional.

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:60
> +        "Apple iOS 11 Release (Build)": {platform: Dashboard.Platform.iOS11Device, debug: false, builder: true, architecture: Buildbot.BuildArchitecture.Universal},
> +        "Apple iOS 11 Simulator Release (Build)": {platform: Dashboard.Platform.iOS11Simulator, debug: false, builder: true, architecture: Buildbot.BuildArchitecture.SixtyFourBit},

These are both single architecture, but have different "architecture" values. We should probably just remove the architecture from configuration.

[Ryan Haddad]

(In reply to Alexey Proskuryakov from comment #2)
> Comment on attachment 321209 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=321209&action=review
> 
> > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:53
> > +                    { "name": "bot216", "platform": "ios-simulator-11" },
> > +                    { "name": "bot217", "platform": "ios-simulator-11" },
> 
> Some of the bots here are no longer used. It's probably still right to make
> the proposed change, but I wanted to point this out to confirm that this is
> intentional.

Thank you for pointing this out. It is intentional and they will be reused in an upcoming patch.

> 
> > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:60
> > +        "Apple iOS 11 Release (Build)": {platform: Dashboard.Platform.iOS11Device, debug: false, builder: true, architecture: Buildbot.BuildArchitecture.Universal},
> > +        "Apple iOS 11 Simulator Release (Build)": {platform: Dashboard.Platform.iOS11Simulator, debug: false, builder: true, architecture: Buildbot.BuildArchitecture.SixtyFourBit},
> 
> These are both single architecture, but have different "architecture"
> values. We should probably just remove the architecture from configuration.

That sounds reasonable. I will make the change.

[Ryan Haddad]

(In reply to Ryan Haddad from comment #3)
> (In reply to Alexey Proskuryakov from comment #2)
> > These are both single architecture, but have different "architecture"
> > values. We should probably just remove the architecture from configuration.
> 
> That sounds reasonable. I will make the change.
It appears that the architecture is required. I will change all three to 'Buildbot.BuildArchitecture.SixtyFourBit'

[Ryan Haddad]

Committed <https://trac.webkit.org/changeset/222229/webkit>.

[Radar WebKit Bug Importer]

<rdar://problem/34693132>