We are currently implementing the selenium legacy ones, we should implement the w3c ones instead. https://w3c.github.io/webdriver/webdriver-spec.html#resizing-and-positioning-windows
Created attachment 321196 [details] Patch
Attachment 321196 [details] did not pass style-queue: ERROR: Source/WebDriver/WebDriverService.h:82: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebDriver/WebDriverService.h:83: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebDriver/Session.h:89: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebDriver/Session.h:90: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebDriver/Session.h:123: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebDriver/Session.h:124: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebDriver/Session.h:125: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebDriver/WebDriverService.cpp:786: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebDriver/WebDriverService.cpp:809: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebDriver/Session.cpp:639: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebDriver/Session.cpp:678: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebDriver/Session.cpp:695: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebDriver/Session.cpp:712: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebDriver/Session.cpp:728: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 14 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 321196 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=321196&action=review r=me > Source/WebDriver/ChangeLog:13 > + (WebDriver::Session::getToplevelBrowsingContextRect): Helper to get the window rext. This is used by both get Nit: 'rect' > Source/WebDriver/Session.cpp:678 > +void Session::moveToplevelBrowsingContextwindow(double x, double y, Function<void (CommandResult&&)>&& completionHandler) Nit: 'moveToplevelBrowsingContextWindow' > Source/WebDriver/Session.cpp:695 > +void Session::resizeToplevelBrowsingContextwindow(double width, double height, Function<void (CommandResult&&)>&& completionHandler) Ditto.
Committed r222256: <http://trac.webkit.org/changeset/222256>
<rdar://problem/34693357>