-Fix can't load https pages. -Build fix for platforms other than Windows. -Replace OS(WINDOWS) with PLATFORM(WIN). -Some style fix.
Created attachment 321189 [details] patch
Comment on attachment 321189 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=321189&action=review > Source/WebCore/platform/network/curl/CurlSSLVerifier.cpp:56 > + if (!verifier) Oh my. Sorry about this.
Comment on attachment 321189 [details] patch I don't see how changing to PLATFORM(WIN) solves anything here.
(In reply to Don Olmstead from comment #3) > Comment on attachment 321189 [details] > patch > > I don't see how changing to PLATFORM(WIN) solves anything here. I guess that for Qt on Windows?
(In reply to Basuke Suzuki from comment #4) > (In reply to Don Olmstead from comment #3) > > Comment on attachment 321189 [details] > > patch > > > > I don't see how changing to PLATFORM(WIN) solves anything here. > > I guess that for Qt on Windows? Believe this is for his Android port. I'm just not sure wanted to know why it would be a problem as android shouldn't be OS(WINDOWS) in this case.
(In reply to Don Olmstead from comment #5) > (In reply to Basuke Suzuki from comment #4) > > (In reply to Don Olmstead from comment #3) > > > Comment on attachment 321189 [details] > > > patch > > > > > > I don't see how changing to PLATFORM(WIN) solves anything here. > > > > I guess that for Qt on Windows? > > Believe this is for his Android port. I'm just not sure wanted to know why > it would be a problem as android shouldn't be OS(WINDOWS) in this case. I'd have kept these changes downstream if it only affects Android port. I submitted it because the guarded code shouldn't be OS dependent.
Comment on attachment 321189 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=321189&action=review I don't understand the need for this patch. > Source/WebCore/ChangeLog:3 > + [Curl] Fix r222147 What exactly does this fix? Does it fix the build? Does it fix https on Windows? Does it fix https on non-windows? Does it fix bypassing certificate warnings on certain systems?
(In reply to Alex Christensen from comment #7) > Comment on attachment 321189 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=321189&action=review > > I don't understand the need for this patch. > > > Source/WebCore/ChangeLog:3 > > + [Curl] Fix r222147 > > What exactly does this fix? Does it fix the build? Does it fix https on > Windows? Does it fix https on non-windows? Does it fix bypassing > certificate warnings on certain systems? Does it fix the build? >> Yes. It fixes building curl without OS(WINDOWS). Does it fix https on Windows? Does it fix https on non-windows? >> Yes. https://bugs.webkit.org/show_bug.cgi?id=177128#c2 Does it fix bypassing certificate warnings on certain systems? >> I don't know. The problem is not loading https pages at all, not bypassing certificate warnings. I'm sure this is needed.
(In reply to Alex Christensen from comment #7) > Comment on attachment 321189 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=321189&action=review > > I don't understand the need for this patch. > > > Source/WebCore/ChangeLog:3 > > + [Curl] Fix r222147 > > What exactly does this fix? Does it fix the build? Does it fix https on > Windows? Does it fix https on non-windows? Does it fix bypassing > certificate warnings on certain systems? Thanks for your review and giving a cq+ but you set r? instead of r+. Is this a mistake or should I have to ask another reviewer to give a r+? Thank you.
Comment on attachment 321189 [details] patch mistake. r=me
Comment on attachment 321189 [details] patch Clearing flags on attachment: 321189 Committed r222248: <http://trac.webkit.org/changeset/222248>
All reviewed patches have been landed. Closing bug.
<rdar://problem/34693341>