Bug 177127 - WebDriver: wrong response in case of errors
Summary: WebDriver: wrong response in case of errors
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebDriver (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-19 02:04 PDT by Carlos Garcia Campos
Modified: 2017-09-27 12:23 PDT (History)
2 users (show)

See Also:

Attachments
Patch (3.80 KB, patch)
2017-09-19 02:15 PDT, Carlos Garcia Campos 		bburg: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-09-19 02:04:24 PDT 
I misunderstood the spec when I implemented this, so we either return a "value" key with the result in case of success or the error object as the body in case of error. We should always add a "value" key to the body and set it with either the result or the error object.

https://w3c.github.io/webdriver/webdriver-spec.html#dfn-send-an-error

Last step is "send a response", which is the same as when there's no error.
Comment 1 Carlos Garcia Campos 2017-09-19 02:15:41 PDT 
Created attachment 321190 [details]
Patch
Comment 2 BJ Burg 2017-09-19 08:46:12 PDT 
Comment on attachment 321190 [details]
Patch

r=me
Comment 3 Carlos Garcia Campos 2017-09-19 23:29:27 PDT 
Committed r222255: <http://trac.webkit.org/changeset/222255>
Comment 4 Radar WebKit Bug Importer 2017-09-27 12:23:56 PDT 
<rdar://problem/34693192>