Bug 177117 – Web Inspector: Adopt named groups in complex regexes

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

Adopt named groups in complex regexes.

We have a few RegExps with 3+ groups:

  • URL parsing
  • Color parsing

Lets use named groups, just introduced in r221769.

[Joseph Pecoraro]

Created attachment 321166 [details]
[PATCH] Proposed Fix

[Build Bot]

Comment on attachment 321166 [details]
[PATCH] Proposed Fix

Attachment 321166 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4589891

New failing tests:
inspector/model/color.html

[Build Bot]

Created attachment 321171 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 321166 [details]
[PATCH] Proposed Fix

Attachment 321166 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4590034

New failing tests:
inspector/model/color.html

[Build Bot]

Created attachment 321173 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Joseph Pecoraro]

Comment on attachment 321166 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=321166&action=review

> Source/WebInspectorUI/UserInterface/Models/Color.js:65
> +            if (match.groups.hex) {
> +                let hex = match.group.hex.toUpperCase();

Oops, the second should be `groups.hex` not `group.hex`.

[Joseph Pecoraro]

Created attachment 321212 [details]
[PATCH] Proposed Fix

[Matt Baker]

Comment on attachment 321212 [details]
[PATCH] Proposed Fix

Nice, r=me.

[WebKit Commit Bot]

Comment on attachment 321212 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 321212

Committed r222216: <http://trac.webkit.org/changeset/222216>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/34693224>