Bug 177114 - REGRESSION(r214494): Web Inspector: Ignore cache button does not work in Network tab
Summary: REGRESSION(r214494): Web Inspector: Ignore cache button does not work in Netw...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-18 17:04 PDT by Joseph Pecoraro
Modified: 2017-09-19 09:03 PDT (History)
5 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (1.75 KB, patch)
2017-09-18 17:07 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2017-09-18 17:04:21 PDT 
Summary:
Ignore cache button does not work in Network tab

Steps to reproduce:
1. Inspect this page
2. Show Network Tab
3. Reload
  => Some resources came from cache
4. Toggle Ignore Cache button to be activated
5. Reload
  => Still shows resources came from cache, expected them not to

Notes:
<https://webkit.org/b/169865> Web Inspector: Add "Disable Caches" option that only applies to the inspected page while Web Inspector is open
<http://trac.webkit.org/changeset/214494>
- The "only do this if enabled" post-review change was too liberal
Comment 1 Radar WebKit Bug Importer 2017-09-18 17:05:44 PDT 
<rdar://problem/34505265>
Comment 2 Joseph Pecoraro 2017-09-18 17:07:19 PDT 
Created attachment 321155 [details]
[PATCH] Proposed Fix
Comment 3 BJ Burg 2017-09-19 08:34:28 PDT 
Comment on attachment 321155 [details]
[PATCH] Proposed Fix

r=me
Comment 4 WebKit Commit Bot 2017-09-19 09:03:12 PDT 
Comment on attachment 321155 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 321155

Committed r222209: <http://trac.webkit.org/changeset/222209>
Comment 5 WebKit Commit Bot 2017-09-19 09:03:14 PDT 
All reviewed patches have been landed.  Closing bug.