Bug 177103 – Make ImageFrame::duration() return Seconds instead of float

• Status: RESOLVED
• Resolution: FIXED
• Component: Images

[Said Abou-Hallawa]

There has been a confusion about the units that this function returns. The ImageFrame is used for two different purposes. It is used by ImageFrameCache to ensure the decoded frame and its meta data are cached when they have to. And it is also used by ScalableImageDecoder to help decoding the image frames fast. The ImageFrame which is cached by ImageFrameCache has the duration in seconds while the ScalableImageDecoder caches its ImageFrame with milli-seconds durations. To clear things, make all the duration in seconds.

[Said Abou-Hallawa]

Created attachment 321131 [details]
Patch

[Said Abou-Hallawa]

Created attachment 321143 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 321143 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321143&action=review

> Source/WebCore/platform/graphics/cg/ImageDecoderCG.cpp:363
> +        return Seconds(0.1f);

0.1_s or 100_ms

> Source/WebCore/platform/graphics/cg/ImageDecoderCG.cpp:364
> +    return Seconds(duration);

Can this just be "return { duration }"?

> Source/WebCore/platform/image-decoders/ScalableImageDecoder.cpp:206
> +        return { };

0_s

> Source/WebCore/platform/image-decoders/ScalableImageDecoder.cpp:212
> +    if (buffer->duration() < Seconds(0.011f))

11_ms

> Source/WebCore/platform/image-decoders/ScalableImageDecoder.cpp:213
> +        return Seconds(0.100f);

100_ms

[Said Abou-Hallawa]

Created attachment 321162 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 321162 [details]
Patch

Clearing flags on attachment: 321162

Committed r222196: <http://trac.webkit.org/changeset/222196>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/34693275>