Turn on ccache for Mac cmake builds by default

[Tim Horton]

Turn on ccache for Mac cmake builds by default

[Tim Horton]

Created attachment 321056 [details]
Patch

[Sam Weinig]

Are there any downsides? Is there a way to disable it if something goes wrong?

[Tim Horton]

(In reply to Sam Weinig from comment #2)
> Are there any downsides?

🤷‍♂️

(but for now this whole build path is totally experimental so it won't affect anyone)

> Is there a way to disable it if something goes wrong?

The zero people working on the Mac CMake build will know how :P

We should probably add an environment variable, though, like we have for the currently-off-by-default Xcode version, and plumb it through build-webkit and friends.

[Geoffrey Garen]

FWIW, I'd prefer an argument to build-webkit over an environment variable.

[Sam Weinig]

(In reply to Geoffrey Garen from comment #4)
> FWIW, I'd prefer an argument to build-webkit over an environment variable.

(In reply to Tim Horton from comment #3)
> (In reply to Sam Weinig from comment #2)
> > Are there any downsides?
> 
> 🤷‍♂️
> 
> (but for now this whole build path is totally experimental so it won't
> affect anyone)
> 
> > Is there a way to disable it if something goes wrong?
> 
> The zero people working on the Mac CMake build will know how :P
> 
> We should probably add an environment variable, though, like we have for the
> currently-off-by-default Xcode version, and plumb it through build-webkit
> and friends.

Given this work is (probably) eventually going to have users, it would be good to get the infrastructure in place early (I, like Geoffrey, prefer a script to an environment variable).

[Tim Horton]

(In reply to Sam Weinig from comment #5)
> (In reply to Geoffrey Garen from comment #4)
> > FWIW, I'd prefer an argument to build-webkit over an environment variable.
> 
> (In reply to Tim Horton from comment #3)
> > (In reply to Sam Weinig from comment #2)
> > > Are there any downsides?
> > 
> > 🤷‍♂️
> > 
> > (but for now this whole build path is totally experimental so it won't
> > affect anyone)
> > 
> > > Is there a way to disable it if something goes wrong?
> > 
> > The zero people working on the Mac CMake build will know how :P
> > 
> > We should probably add an environment variable, though, like we have for the
> > currently-off-by-default Xcode version, and plumb it through build-webkit
> > and friends.
> 
> Given this work is (probably) eventually going to have users, it would be
> good to get the infrastructure in place early (I, like Geoffrey, prefer a
> script to an environment variable).

When I said "an environment variable ... and plumb it through build-webkit and friends", I meant "an argument to build-webkit that sets the environment variable", which I think satisfies your desires?

I think we want an environment variable underneath so that it can be set with e.g. `make` and `xcodebuild`, and so that it can be identical to the flag that we already use in `xcodebuild` (which is currently an enable flag instead of a disable flag, but ... identical to it once we flip it).

[Tim Horton]

Created attachment 324498 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 324498 [details]
Patch

Clearing flags on attachment: 324498

Committed r223818: <https://trac.webkit.org/changeset/223818>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/35568833>