Bug 177054 - Web Inspector: console.assert messages shouldn't end in an exclamation point
Summary: Web Inspector: console.assert messages shouldn't end in an exclamation point
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-17 09:48 PDT by Matt Baker
Modified: 2017-09-27 12:25 PDT (History)
4 users (show)

See Also:


Attachments
Patch (5.53 KB, patch)
2017-09-17 09:50 PDT, Matt Baker
no flags Details | Formatted Diff | Diff
Patch for landing (5.50 KB, patch)
2017-09-18 11:57 PDT, Matt Baker
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2017-09-17 09:48:44 PDT
No need to be so dramatic.
Comment 1 Matt Baker 2017-09-17 09:50:59 PDT
Created attachment 321046 [details]
Patch
Comment 2 Joseph Pecoraro 2017-09-18 11:51:08 PDT
Comment on attachment 321046 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321046&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/Resizer.js:76
> +        console.assert(false, `Unexpected Resizer orientation: ${this._orientation}.`);

I'd prefer including the orientation as its own parameter instead of an inline string.

    console.assert(false, "Unexpected Resizer orientation", this._orientation);
Comment 3 Matt Baker 2017-09-18 11:57:42 PDT
Created attachment 321120 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2017-09-18 12:35:21 PDT
Comment on attachment 321120 [details]
Patch for landing

Clearing flags on attachment: 321120

Committed r222174: <http://trac.webkit.org/changeset/222174>
Comment 5 WebKit Commit Bot 2017-09-18 12:35:23 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-09-27 12:25:48 PDT
<rdar://problem/34693261>