Bug 177049 – [Harfbuzz] adjustSelectionRectForComplexText() should also pass the character range when shaping

• Status: RESOLVED
• Resolution: FIXED
• Component: Text

[Carlos Garcia Campos]

Now that the shaper support receiving a range we should use that also in adjustSelectionRectForComplexText(). This will ensure consistent results with getGlyphsAndAdvancesForComplexText().

[Carlos Garcia Campos]

Created attachment 321040 [details]
Patch

[Michael Catanzaro]

Comment on attachment 321040 [details]
Patch

What test does this fix?

[Carlos Garcia Campos]

(In reply to Michael Catanzaro from comment #2)
> Comment on attachment 321040 [details]
> Patch
> 
> What test does this fix?

This doesn't affect test results.

[WebKit Commit Bot]

Comment on attachment 321040 [details]
Patch

Rejecting attachment 321040 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 321040, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
ing rebase:
:040000 040000 6e14de628b80008549948a8e0122f4bf62c40f9a 86a8d7212f99ef652aa59bf346f93989ecd2afbd M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
Current branch master is up to date.

Full output: http://webkit-queues.webkit.org/results/4580742

[Carlos Garcia Campos]

Committed r222202: <http://trac.webkit.org/changeset/222202>

[Radar WebKit Bug Importer]

<rdar://problem/34693439>