Bug 177028 – Avoid calling String::format() in PlatformCAFilters::setFiltersOnLayer()

• Status: RESOLVED
• Resolution: FIXED
• Component: Animations

[Said Abou-Hallawa]

From instrumenting the MotionMark Focus test with fixed complexity, this function alone takes 2% of the execution time.

[Said Abou-Hallawa]

Created attachment 320969 [details]
Patch

[Tim Horton]

Comment on attachment 320969 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320969&action=review

> Source/WebCore/ChangeLog:8
> +        String::fromat() is a bigger hammer for what we need to do in this function.

FROMAT

> Source/WebCore/platform/graphics/ca/cocoa/PlatformCAFiltersCocoa.mm:71
> +    static NeverDestroyed<String> filterNamePrefix ="filter_";

There's a missing space after the =. Also isn't there a way to make this more efficient b/c it comes from a literal (something like ASCIILiteral? or does that just happen magically? I don't know. Look around.)

[Said Abou-Hallawa]

Created attachment 320976 [details]
Patch

[Said Abou-Hallawa]

Created attachment 320984 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 320984 [details]
Patch

Clearing flags on attachment: 320984

Committed r222125: <http://trac.webkit.org/changeset/222125>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Sam Weinig]

Comment on attachment 320984 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320984&action=review

> Source/WebCore/platform/graphics/ca/cocoa/PlatformCAFiltersCocoa.mm:74
> +        String filterName = filterNamePrefix.get() + String::number(i);

For the future, this could be make more efficient by doing:

#include <wtf/text/StringConcatenate.h>
#include <wtf/text/StringConcatenateNumbers.h>

auto filterName = makeString("filter_", i);

[Radar WebKit Bug Importer]

<rdar://problem/34693768>