Bug 177022 - Expose WKPageRef as a private property on WKWebView on Mac
Summary: Expose WKPageRef as a private property on WKWebView on Mac
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-15 13:08 PDT by Alex Christensen
Modified: 2017-09-27 12:28 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.23 KB, patch)
2017-09-15 13:09 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (2.21 KB, patch)
2017-09-18 10:53 PDT, Alex Christensen
aestes: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2017-09-15 13:08:47 PDT
Expose WKPageRef as a private property on WKWebView on Mac
Comment 1 Alex Christensen 2017-09-15 13:09:26 PDT
Created attachment 320954 [details]
Patch
Comment 2 Geoffrey Garen 2017-09-15 14:35:19 PDT
CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/MiniBrowser.build/Release/MiniBrowser.build/Objects-normal/x86_64/WK2BrowserWindowController.o mac/WK2BrowserWindowController.m normal x86_64 objective-c com.apple.compilers.llvm.clang.1_0.compiler
    cd /Volumes/Data/EWS/WebKit/Tools/MiniBrowser
    export LANG=en_US.US-ASCII
    /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -x objective-c -arch x86_64 -fmessage-length=0 -fdiagnostics-show-note-include-stack -fmacro-backtrace-limit=0 -std=gnu99 -gmodules -Wno-trigraphs -fpascal-strings -Os -fno-common -Werror -Wno-missing-field-initializers -Wno-missing-prototypes -Wunreachable-code -Wno-implicit-atomic-properties -Wno-arc-repeated-use-of-weak -Wduplicate-method-match -Wno-missing-braces -Wparentheses -Wswitch -Wunused-function -Wno-unused-label -Wno-unused-parameter -Wunused-variable -Wunused-value -Wempty-body -Wuninitialized -Wno-unknown-pragmas -Wno-shadow -Wno-four-char-constants -Wno-conversion -Wconstant-conversion -Wint-conversion -Wbool-conversion -Wenum-conversion -Wshorten-64-to-32 -Wpointer-sign -Wno-newline-eof -Wno-selector -Wno-strict-selector-match -Wundeclared-selector -Wno-deprecated-implementations -DOBJC_OLD_DISPATCH_PROTOTYPES=0 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk -fasm-blocks -fstrict-aliasing -Wprotocol -Wdeprecated-declarations -mmacosx-version-min=10.11 -g -fvisibility=hidden -Wno-sign-conversion -I/Volumes/Data/EWS/WebKit/WebKitBuild/MiniBrowser.build/Release/MiniBrowser.build/MiniBrowser.hmap -I/Volumes/Data/EWS/WebKit/WebKitBuild/Release/include -I/Volumes/Data/EWS/WebKit/WebKitBuild/MiniBrowser.build/Release/MiniBrowser.build/DerivedSources/x86_64 -I/Volumes/Data/EWS/WebKit/WebKitBuild/MiniBrowser.build/Release/MiniBrowser.build/DerivedSources -Wall -W -Wno-unused-parameter -F/Volumes/Data/EWS/WebKit/WebKitBuild/Release -include /Volumes/Data/EWS/WebKit/WebKitBuild/PrecompiledHeaders/MiniBrowser_Prefix-azlouqjfvuumbxarszjzphftatda/MiniBrowser_Prefix.pch -MMD -MT dependencies -MF /Volumes/Data/EWS/WebKit/WebKitBuild/MiniBrowser.build/Release/MiniBrowser.build/Objects-normal/x86_64/WK2BrowserWindowController.d --serialize-diagnostics /Volumes/Data/EWS/WebKit/WebKitBuild/MiniBrowser.build/Release/MiniBrowser.build/Objects-normal/x86_64/WK2BrowserWindowController.dia -c /Volumes/Data/EWS/WebKit/Tools/MiniBrowser/mac/WK2BrowserWindowController.m -o /Volumes/Data/EWS/WebKit/WebKitBuild/MiniBrowser.build/Release/MiniBrowser.build/Objects-normal/x86_64/WK2BrowserWindowController.o
In file included from /Volumes/Data/EWS/WebKit/Tools/MiniBrowser/mac/WK2BrowserWindowController.m:37:
In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebKit.framework/PrivateHeaders/WKUIDelegatePrivate.h:32:
/Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebKit.framework/PrivateHeaders/WKWebViewPrivate.h:71:36: error: redefinition of typedef 'WKPageRef' is a C11 feature [-Werror,-Wtypedef-redefinition]
typedef const struct OpaqueWKPage* WKPageRef;
                                   ^
In file included from /Volumes/Data/EWS/WebKit/Tools/MiniBrowser/mac/WK2BrowserWindowController.m:35:
In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebKit.framework/PrivateHeaders/WKPreferencesPrivate.h:26:
In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebKit.framework/PrivateHeaders/WKPreferencesRefPrivate.h:29:
/Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebKit.framework/PrivateHeaders/WKBase.h:111:36: note: previous definition is here
typedef const struct OpaqueWKPage* WKPageRef;
                                   ^
1 error generated.
Comment 3 Alex Christensen 2017-09-18 10:53:15 PDT
Created attachment 321108 [details]
Patch
Comment 4 Alex Christensen 2017-09-19 10:45:19 PDT
http://trac.webkit.org/r222212
Comment 5 Radar WebKit Bug Importer 2017-09-27 12:28:31 PDT
<rdar://problem/34693346>