Bug 177015 - Fix the macOS CMake build
Summary: Fix the macOS CMake build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-15 11:09 PDT by Tim Horton
Modified: 2017-09-27 12:31 PDT (History)
6 users (show)

See Also:

Attachments
Patch (11.61 KB, patch)
2017-09-15 11:09 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (11.54 KB, patch)
2017-09-15 11:52 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2017-09-15 11:09:03 PDT 
Fix the macOS CMake build
Comment 1 Tim Horton 2017-09-15 11:09:21 PDT 
Created attachment 320929 [details]
Patch
Comment 2 Tim Horton 2017-09-15 11:50:04 PDT 
Apparently I didn't get that quite right.
Comment 3 Alex Christensen 2017-09-15 11:51:41 PDT 
Comment on attachment 320929 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320929&action=review

> Source/WebKit/CMakeLists.txt:261
> +    Shared/cf/CookieStorageUtilsCF.mm

Yep, put this in PlatformMac
Comment 4 Tim Horton 2017-09-15 11:52:44 PDT 
Created attachment 320937 [details]
Patch
Comment 5 Tim Horton 2017-09-15 11:52:55 PDT 
Indeed.
Comment 6 WebKit Commit Bot 2017-09-15 12:53:05 PDT 
Comment on attachment 320937 [details]
Patch

Clearing flags on attachment: 320937

Committed r222103: <http://trac.webkit.org/changeset/222103>
Comment 7 WebKit Commit Bot 2017-09-15 12:53:07 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2017-09-27 12:31:04 PDT 
<rdar://problem/34693414>