Bug 176964 – Create a launcher for webkit-archives

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Lucas Forschler]

The Apple webkit archives produced by build.webkit.org have no easy way of launching without a WebKit checkout.
This bug will track creating a wrapper to be included in the archives such that they can be launched.

[Radar WebKit Bug Importer]

<rdar://problem/34445629>

[Lucas Forschler]

Created attachment 320838 [details]
v1 patch for review

[Lucas Forschler]

Created attachment 320842 [details]
v1 patch for review

[Aakash Jain]

Comment on attachment 320842 [details]
v1 patch for review

View in context: https://bugs.webkit.org/attachment.cgi?id=320842&action=review

> Tools/Scripts/run-webkit-archive:34
> +    current_directory = os.path.abspath(os.path.join(script_path,os.pardir))

Is this code to get the directory name? 
You can probably do current_directory = os.path.dirname(script_path)

> Tools/Scripts/run-webkit-archive:41
> +        print('No Release or Debug framework directories found, exiting.')

This message can use some polishing, maybe specify where are Release or Debug directories not found.

> Tools/Scripts/run-webkit-archive:55
> +    script_directory = os.path.dirname(script_path)

script_directory seems to be unused

> Tools/Scripts/run-webkit-archive:61
> +        if 'Darwin' not in platform.system():

This code should be made a separate function and called from inside main(). e.g.: check_for_valid_platform()

[Lucas Forschler]

Committed revision 222067.