Bug 176964 - Create a launcher for webkit-archives
Summary: Create a launcher for webkit-archives
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Lucas Forschler
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-14 15:57 PDT by Lucas Forschler
Modified: 2017-09-14 17:14 PDT (History)
4 users (show)

See Also:


Attachments
v1 patch for review (4.03 KB, patch)
2017-09-14 15:59 PDT, Lucas Forschler
lforschler: commit-queue-
Details | Formatted Diff | Diff
v1 patch for review (4.03 KB, patch)
2017-09-14 16:28 PDT, Lucas Forschler
aakash_jain: review+
lforschler: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Forschler 2017-09-14 15:57:32 PDT
The Apple webkit archives produced by build.webkit.org have no easy way of launching without a WebKit checkout.
This bug will track creating a wrapper to be included in the archives such that they can be launched.
Comment 1 Radar WebKit Bug Importer 2017-09-14 15:58:05 PDT
<rdar://problem/34445629>
Comment 2 Lucas Forschler 2017-09-14 15:59:33 PDT
Created attachment 320838 [details]
v1 patch for review
Comment 3 Lucas Forschler 2017-09-14 16:28:31 PDT
Created attachment 320842 [details]
v1 patch for review
Comment 4 Aakash Jain 2017-09-14 16:52:33 PDT
Comment on attachment 320842 [details]
v1 patch for review

View in context: https://bugs.webkit.org/attachment.cgi?id=320842&action=review

> Tools/Scripts/run-webkit-archive:34
> +    current_directory = os.path.abspath(os.path.join(script_path,os.pardir))

Is this code to get the directory name? 
You can probably do current_directory = os.path.dirname(script_path)

> Tools/Scripts/run-webkit-archive:41
> +        print('No Release or Debug framework directories found, exiting.')

This message can use some polishing, maybe specify where are Release or Debug directories not found.

> Tools/Scripts/run-webkit-archive:55
> +    script_directory = os.path.dirname(script_path)

script_directory seems to be unused

> Tools/Scripts/run-webkit-archive:61
> +        if 'Darwin' not in platform.system():

This code should be made a separate function and called from inside main(). e.g.: check_for_valid_platform()
Comment 5 Lucas Forschler 2017-09-14 17:14:27 PDT
Committed revision 222067.