Bug 176954 - Make dumping the graph print when both when exitOK and !exitOK
Summary: Make dumping the graph print when both when exitOK and !exitOK
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-14 13:41 PDT by Saam Barati
Modified: 2017-09-27 12:36 PDT (History)
13 users (show)

See Also:

Attachments
patch (1.30 KB, patch)
2017-09-14 16:17 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2017-09-14 13:41:25 PDT 
Currently, we only print when !exitOK. I think it'd be helpful to also print when it's valid to make reading the dump more explicit.
Comment 1 Saam Barati 2017-09-14 16:17:35 PDT 
Created attachment 320839 [details]
patch
Comment 2 Keith Miller 2017-09-14 16:18:15 PDT 
Comment on attachment 320839 [details]
patch

r=me.
Comment 3 WebKit Commit Bot 2017-09-14 17:04:50 PDT 
Comment on attachment 320839 [details]
patch

Clearing flags on attachment: 320839

Committed r222066: <http://trac.webkit.org/changeset/222066>
Comment 4 WebKit Commit Bot 2017-09-14 17:04:52 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2017-09-27 12:36:22 PDT 
<rdar://problem/34693583>