Bug 176931 - [Mac] Upstream SpeechSynthesis-related WebKitSystemInterface functions
Summary: [Mac] Upstream SpeechSynthesis-related WebKitSystemInterface functions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-14 11:31 PDT by Andy Estes
Modified: 2017-09-27 12:36 PDT (History)
7 users (show)

See Also:

Attachments
Patch (11.47 KB, patch)
2017-09-14 11:33 PDT, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch (14.37 KB, patch)
2017-09-14 11:50 PDT, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch (14.31 KB, patch)
2017-09-14 13:41 PDT, Andy Estes 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2017-09-14 11:31:58 PDT 
[Mac] Upstream SpeechSynthesis-related WebKitSystemInterface functions
Comment 1 Andy Estes 2017-09-14 11:33:56 PDT Comment hidden (obsolete)
Comment 2 Andy Estes 2017-09-14 11:50:54 PDT 
Created attachment 320798 [details]
Patch
Comment 3 Joseph Pecoraro 2017-09-14 11:54:25 PDT 
Comment on attachment 320798 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320798&action=review

rs=me

> Source/WebCore/platform/mac/PlatformSpeechSynthesizerMac.mm:221
> +    // By default speech only returns a "premium" voices, which does not include all the

Grammar: "returns a premium voices" => "returns premium voices"
Comment 4 Andy Estes 2017-09-14 13:41:37 PDT 
Created attachment 320813 [details]
Patch
Comment 5 WebKit Commit Bot 2017-09-14 14:24:01 PDT 
Comment on attachment 320813 [details]
Patch

Clearing flags on attachment: 320813

Committed r222053: <http://trac.webkit.org/changeset/222053>
Comment 6 WebKit Commit Bot 2017-09-14 14:24:02 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-09-27 12:36:31 PDT 
<rdar://problem/34693591>