Bug 17691 - REGRESSION: FindSafari doesn't work
Summary: REGRESSION: FindSafari doesn't work
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P1 Normal
Assignee: Nobody
URL:
Keywords: PlatformOnly, Regression
Depends on:
Blocks:
 
Reported: 2008-03-05 18:25 PST by Robert Xiao
Modified: 2008-06-25 14:24 PDT (History)
5 users (show)

See Also:


Attachments
s/Debug/Release (3.58 KB, patch)
2008-03-06 07:05 PST, Matt Lilek
aroben: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Xiao 2008-03-05 18:25:34 PST
I downloaded the very latest nightly (r30768) and found that the FindSafari.exe program doesn't start with this error:

This application has failed to start because the application configuration is incorrect. Reinstalling the application may fix this problem.

I have reinstalled Safari 3.0.4 and redownloaded/unpacked the package, to no avail. The older FindSafari from r30628 works fine, even with the new nightly. Also, the old one is 10.5 KB; the new one is 39.0 KB.

The second issue (cosmetic) is that after starting WebKit with run-nightly-webkit.cmd, the version number as reported by Safari is still 523.15. I know I am running WebKit, though, because it gets a high score (88) on Acid3 (among other things), while regular Safari (when run directly) gets 39.
Comment 1 Mark Rowe (bdash) 2008-03-05 19:15:47 PST
How are you checking the WebKit version number?  Safari's "About" box displays Safari's version number, not WebKit's, so it will be unaffected by running a nightly build.
Comment 2 Robert Xiao 2008-03-05 19:24:59 PST
I am using Help->About. I couldn't find out how to do it any other way. Is there an about: page for it?
Comment 3 Adam Roben (:aroben) 2008-03-05 19:49:47 PST
(In reply to comment #2)
> I am using Help->About. I couldn't find out how to do it any other way. Is
> there an about: page for it?

No, the WebKit version number is not shown anywhere in Safari's UI. It is, however, included in the user agent string, and sites like <http://whatsmyuseragent.com/> make it easy to see the contents of that string.
Comment 4 Robert Xiao 2008-03-05 20:08:32 PST
OK, so that's not a bug. Thanks for letting me know. The FindSafari thing is still problematic, though.
Comment 5 Adam Roben (:aroben) 2008-03-05 20:25:26 PST
The r30768 nightly works just fine for me on XP Pro SP 2 (I'm using it right now to write this comment).

Perhaps you should try deleting the %TMP%\WebKitNightly directory and running the nightly again?
Comment 6 Robert Xiao 2008-03-05 20:27:55 PST
Cleared out my temp directory. Same error, if I use the new FindSafari.
Comment 7 Robert Xiao 2008-03-05 20:29:32 PST
I should add that it works (but seems to crash on RSS feeds, something I can't seem to reproduce always).
Comment 8 Adam Roben (:aroben) 2008-03-05 20:39:19 PST
(In reply to comment #7)
> I should add that it works (but seems to crash on RSS feeds, something I can't
> seem to reproduce always).

Does this mean that Safari now launches and you no longer get the error dialog?

Comment 9 Adam Roben (:aroben) 2008-03-05 20:44:56 PST
(In reply to comment #0)
> I downloaded the very latest nightly (r30768) and found that the FindSafari.exe
> program doesn't start with this error:
> 
> This application has failed to start because the application configuration is
> incorrect. Reinstalling the application may fix this problem.
> 
> The older FindSafari from r30628 works fine, even with the new nightly.
> Also, the old one is 10.5 KB; the new one is 39.0 KB.

It's been suggested that this is all caused by r30394 <http://trac.webkit.org/projects/webkit/changeset/30394>, which caused FindSafari to always link against the debug C runtime. This makes sense to me, though it doesn't explain why r30628 works for you.

Perhaps we should change FindSafari to always link against the release C runtime.
> 
> The second issue (cosmetic) is that after starting WebKit with
> run-nightly-webkit.cmd, the version number as reported by Safari is still
> 523.15. I know I am running WebKit, though, because it gets a high score (88)
> on Acid3 (among other things), while regular Safari (when run directly) gets
> 39.
> 

Comment 10 Robert Xiao 2008-03-05 20:50:16 PST
Safari only launches (and works, and crashes randomly on RSS...) if the FindSafari.exe file is the one from the r30628 package (posted in the Windows nightlies archive). Simply using the run-nightly-webkit.cmd script with the newer (broken) FindSafari results in the console window appearing momentarily; no dialog error is shown, and Safari doesn't start (as verified by the Process Manager).

If I add a pause statement, the output is:
        1 file(s) copied.
The system cannot execute the specified program.
Setting environment for using Microsoft Visual Studio 2005 x86 tools.
Comment 11 Robert Blaut 2008-03-05 23:08:36 PST
I can confirm the problem. After executing  a script "run-webkit-nightly.cmd" I get "the system cannot execute the specified program".
Comment 12 Robert Blaut 2008-03-05 23:09:21 PST
Marked as regression P1 bug.
Comment 13 Matt Lilek 2008-03-06 06:51:37 PST
(In reply to comment #9)
> (In reply to comment #0)
> > I downloaded the very latest nightly (r30768) and found that the FindSafari.exe
> > program doesn't start with this error:
> > 
> > This application has failed to start because the application configuration is
> > incorrect. Reinstalling the application may fix this problem.
> > 
> > The older FindSafari from r30628 works fine, even with the new nightly.
> > Also, the old one is 10.5 KB; the new one is 39.0 KB.
> 
> It's been suggested that this is all caused by r30394
> <http://trac.webkit.org/projects/webkit/changeset/30394>, which caused
> FindSafari to always link against the debug C runtime. This makes sense to me,
> though it doesn't explain why r30628 works for you.
> 
> Perhaps we should change FindSafari to always link against the release C
> runtime.
>

I just changed it to use our release vsprops instead of the debug ones and the nightly works fine now on my non-dev Vista work box.
Comment 14 Matt Lilek 2008-03-06 07:05:35 PST
Created attachment 19569 [details]
s/Debug/Release
Comment 15 Adam Roben (:aroben) 2008-03-06 07:13:52 PST
Comment on attachment 19569 [details]
s/Debug/Release

r=me
Comment 16 Matt Lilek 2008-03-06 16:30:46 PST
Fix landed in r30864, it will be included in the next nightly.
Comment 17 Robert Xiao 2008-03-06 20:15:40 PST
FindSafari still doesn't work in r30865, giving the exact same problem as before; the file is 39.0 KB (same size as the not-working r30768 version, but the md5sums are different).

The old version from r30628 still works fine.
Comment 18 Matt Lilek 2008-03-06 20:19:06 PST
(In reply to comment #17)
> FindSafari still doesn't work in r30865, giving the exact same problem as
> before; the file is 39.0 KB (same size as the not-working r30768 version, but
> the md5sums are different).
> 
> The old version from r30628 still works fine.
> 

It's an issue with the way the nightlies are being built/packaged.
Comment 19 Robert Xiao 2008-03-06 20:28:26 PST
Alright, I see. Well, I'll continue to use the old FindSafari for now, then. Is there a possibility that using this "outdated" version is resulting in my non-reproducible random crashes, or might that be something else?
Comment 20 Robert Xiao 2008-03-06 20:28:47 PST
Sorry, I checked the wrong box. It's not fixed.
Comment 21 Matt Lilek 2008-03-06 20:31:50 PST
(In reply to comment #19)
> Alright, I see. Well, I'll continue to use the old FindSafari for now, then. Is
> there a possibility that using this "outdated" version is resulting in my
> non-reproducible random crashes, or might that be something else?
> 

No - there haven't been any changes to FindSafari is awhile so the "old" version you have will be identical to the "correct" one in ToT.
Comment 22 Mark Rowe (bdash) 2008-03-06 20:53:00 PST
Grab the latest nightly build (r30868).  It was just fixed.
Comment 23 Robert Xiao 2008-03-06 20:56:02 PST
I can verify that it is fixed. Thanks!
Comment 24 Γριφεγ 2008-06-25 07:50:55 PDT
No it is not fixed!

I have just downloaded the r34752 nightly.

It still exhibits the same problem on Windows XP!
Comment 25 Mark Rowe (bdash) 2008-06-25 14:00:41 PDT
Given that this bug report was closed *three months ago*, any issue that you are seeing should be filed as a separate bug report as it's likely to be an unrelated issue.
Comment 26 Γριφεγ 2008-06-25 14:24:43 PDT
Oops... Not having Safari installed results in the same symptoms as this bug.

The WebKit nightly download site should tell the rest of us that it needs a Safari installation, I think...