Bug 176907 - [FreeType] Complex text is enabled too often after r221909
Summary: [FreeType] Complex text is enabled too often after r221909
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, InRadar
Depends on:
Blocks:
 
Reported: 2017-09-14 08:42 PDT by Carlos Garcia Campos
Modified: 2017-09-27 12:36 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.66 KB, patch)
2017-09-14 08:44 PDT, Carlos Garcia Campos 		svillar: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-09-14 08:42:38 PDT 
In r221909 we enabled complex text by default following the same cocoa ifdefs, but I forgot another ifdef in the cpp file. This is going to require another rebaseline fo 2200 tests. I hope it will be the last one.
Comment 1 Carlos Garcia Campos 2017-09-14 08:44:16 PDT 
Created attachment 320769 [details]
Patch
Comment 2 Carlos Garcia Campos 2017-09-15 00:08:36 PDT 
Committed r222077: <http://trac.webkit.org/changeset/222077>
Comment 3 Claudio Saavedra 2017-09-15 03:06:44 PDT 
After this change there's massive WPE test failure in the bots. Not sure what's going on.. https://build.webkit.org/builders/WPE%20Linux%2064-bit%20Release%20%28Tests%29/builds/2820
Comment 4 Claudio Saavedra 2017-09-15 03:07:17 PDT 
(In reply to Carlos Garcia Campos from comment #0)
> In r221909 we enabled complex text by default following the same cocoa
> ifdefs, but I forgot another ifdef in the cpp file. This is going to require
> another rebaseline fo 2200 tests. I hope it will be the last one.

> This is going to require another rebaseline fo 2200 tests. I hope it will be the last one.

Ah, sorry. I should read before commenting.
Comment 5 Radar WebKit Bug Importer 2017-09-27 12:36:33 PDT 
<rdar://problem/34693592>