Web timing related information gathering is redundant in Curl port. We replace them with NetworkLoadMetrics class and set the network load metrics correctly.
Created attachment 320770 [details] patch
Comment on attachment 320770 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=320770&action=review > Source/WebCore/platform/network/curl/CurlContext.h:294 > + CURLcode getTimes(double&, double&, double&, double&, double&) const; We're trying to move away from passing return value references in as parameters. Let's make this be a function that takes no parameters and returns a std::optional<NetworkLoadMetrics> or if you actually need the code a WTF::Expected<NetworkLoadMetrics, CURLcode>. The functions above it could use the same improvement.
Other than that this looks good.
Created attachment 320804 [details] Fixed
Attachment 320804 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 320804 [details] Fixed View in context: https://bugs.webkit.org/attachment.cgi?id=320804&action=review > Source/WebCore/platform/network/curl/CurlContext.cpp:590 > +std::optional<long> CurlHandle::getPrimaryPort() Ports are uint16_t's. It might be worth range checking and returning a std::optional<uint16_t> > Source/WebCore/platform/network/curl/CurlDownload.cpp:186 > + if (*httpCode >= 200 && *httpCode < 300) { This is now unchecked use of a std::optional.
Created attachment 320824 [details] patch
Comment on attachment 320824 [details] patch Clearing flags on attachment: 320824 Committed r222068: <http://trac.webkit.org/changeset/222068>
All reviewed patches have been landed. Closing bug.
<rdar://problem/34693311>