Bug 176891 - [WinCairo] Add an option to build WebKitLegacy or WebKit
Summary: [WinCairo] Add an option to build WebKitLegacy or WebKit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 174003
  Show dependency treegraph
 
Reported: 2017-09-13 23:54 PDT by Yousuke Kimoto
Modified: 2017-09-27 12:34 PDT (History)
5 users (show)

See Also:


Attachments
[PATCH] Add an option to build WebKitLegacy or WebKit (2.30 KB, patch)
2017-09-14 01:45 PDT, Yousuke Kimoto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yousuke Kimoto 2017-09-13 23:54:10 PDT
To build WebKitLegacy and WebKit on WinCairo,  we'd like to introduce ENABLE_WEBKIT_LEGACY for WInCiaro's CMake files to choose the two architecture.

For WebKitLegacy:
$ perl Tools\Scripts\build-webkit --no-ninja --wincairo --64-bit

For WebKit:
$ perl Tools\Scripts\build-webkit --no-ninja --64-bit --wincairo --cmakeargs="-DENABLE_WEBKIT_LEGACY=OFF"
Comment 1 Yousuke Kimoto 2017-09-14 01:45:14 PDT
Created attachment 320749 [details]
[PATCH] Add an option to build WebKitLegacy or WebKit
Comment 2 Alex Christensen 2017-09-14 10:46:31 PDT
Comment on attachment 320749 [details]
[PATCH] Add an option to build WebKitLegacy or WebKit

Won't we want to add an else to both of these conditions?
Comment 3 Don Olmstead 2017-09-14 18:13:54 PDT
Comment on attachment 320749 [details]
[PATCH] Add an option to build WebKitLegacy or WebKit

Ok so I got some clarification this will work with the following command

perl Tools\Scripts\build-webkit --64-bit --wincairo --cmakeargs="-DENABLE_WEBKIT_LEGACY=OFF"

In this case the root CMakeLists.txt has

if (NOT DEFINED ENABLE_WEBKIT)
    set(ENABLE_WEBKIT ON)
endif ()

So this will end up building with WebKit instead of WebKitLegacy.
Comment 4 WebKit Commit Bot 2017-09-14 18:42:56 PDT
Comment on attachment 320749 [details]
[PATCH] Add an option to build WebKitLegacy or WebKit

Clearing flags on attachment: 320749

Committed r222070: <http://trac.webkit.org/changeset/222070>
Comment 5 WebKit Commit Bot 2017-09-14 18:42:57 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-09-27 12:34:13 PDT
<rdar://problem/34693503>