Bug 176891 – [WinCairo] Add an option to build WebKitLegacy or WebKit

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Yousuke Kimoto]

To build WebKitLegacy and WebKit on WinCairo,  we'd like to introduce ENABLE_WEBKIT_LEGACY for WInCiaro's CMake files to choose the two architecture.

For WebKitLegacy:
$ perl Tools\Scripts\build-webkit --no-ninja --wincairo --64-bit

For WebKit:
$ perl Tools\Scripts\build-webkit --no-ninja --64-bit --wincairo --cmakeargs="-DENABLE_WEBKIT_LEGACY=OFF"

[Yousuke Kimoto]

Created attachment 320749 [details]
[PATCH] Add an option to build WebKitLegacy or WebKit

[Alex Christensen]

Comment on attachment 320749 [details]
[PATCH] Add an option to build WebKitLegacy or WebKit

Won't we want to add an else to both of these conditions?

[Don Olmstead]

Comment on attachment 320749 [details]
[PATCH] Add an option to build WebKitLegacy or WebKit

Ok so I got some clarification this will work with the following command

perl Tools\Scripts\build-webkit --64-bit --wincairo --cmakeargs="-DENABLE_WEBKIT_LEGACY=OFF"

In this case the root CMakeLists.txt has

if (NOT DEFINED ENABLE_WEBKIT)
    set(ENABLE_WEBKIT ON)
endif ()

So this will end up building with WebKit instead of WebKitLegacy.

[WebKit Commit Bot]

Comment on attachment 320749 [details]
[PATCH] Add an option to build WebKitLegacy or WebKit

Clearing flags on attachment: 320749

Committed r222070: <http://trac.webkit.org/changeset/222070>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/34693503>