Bug 176889 – Add WKUIDelegatePrivate equivalent of WKPageUIClient's drawHeader, drawFooter, headerHeight, and footerHeight

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alex Christensen]

Add WKUIDelegatePrivate equivalent of WKPageUIClient's drawHeader, drawFooter, headerHeight, and footerHeight

[Alex Christensen]

Created attachment 320729 [details]
Patch

[Alex Christensen]

Created attachment 320737 [details]
Patch

[Build Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Andy Estes]

Comment on attachment 320737 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320737&action=review

> Source/WebKit/UIProcess/WebFrameProxy.cpp:79
> +void WebFrameProxy::loadURL(const WebCore::URL& url)

There's a "using namespace WebCore" at the top of this file, so you don't need to specify "WebCore::" here.

> Source/WebKit/UIProcess/WebPageProxy.cpp:964
> +void WebPageProxy::loadAlternateHTMLString(const String& htmlString, const WebCore::URL& baseURL, const WebCore::URL& unreachableURL, API::Object* userData)

Ditto.

> Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:2495
> +    getPage(webView).loadAlternateHTMLString(String::fromUTF8(content), WebCore::URL(WebCore::URL(), String::fromUTF8(baseURI)), WebCore::URL(WebCore::URL(), String::fromUTF8(contentURI)));

Ditto.

[Alex Christensen]

Created attachment 320790 [details]
Patch

[Alex Christensen]

http://trac.webkit.org/r222033

[Ryan Haddad]

API test WebKit.PrintFrame is timing out after this change:
https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20WK2%20%28Tests%29/builds/4465

[Ryan Haddad]

Reverted r222033 for reason:

This change caused API test WebKit.PrintFrame to time out.

Committed r222047: <http://trac.webkit.org/changeset/222047>

[Alex Christensen]

Created attachment 320844 [details]
Patch

[Alex Christensen]

So it turns out the exact call order and number to these delegate callbacks are not the same on all mac platforms.  I modified the test to verify that each delegate is called at least once, and I check the values as before.

http://trac.webkit.org/r222059

[Radar WebKit Bug Importer]

<rdar://problem/34694441>