Bug 176886 - [CMake] Detect harfbuzz without pkgconfig
Summary: [CMake] Detect harfbuzz without pkgconfig
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-13 18:07 PDT by Don Olmstead
Modified: 2017-09-27 12:28 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.07 KB, patch)
2017-09-13 18:17 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
Patch (3.08 KB, patch)
2017-09-13 18:23 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2017-09-13 18:07:40 PDT 
Currently harfbuzz is not able to be detected without pkgconfig which isn't typically used on windows.
Comment 1 Don Olmstead 2017-09-13 18:17:06 PDT 
Created attachment 320718 [details]
Patch

Detects harfbuzz without pkgconfig. Will determine the version from the header file directly.
Comment 2 Build Bot 2017-09-13 18:20:16 PDT 
Attachment 320718 [details] did not pass style-queue:


ERROR: Source/cmake/FindHarfBuzz.cmake:54:  One space between command "endif" and its parentheses, should be "endif ("  [whitespace/parentheses] [5]
ERROR: Source/cmake/FindHarfBuzz.cmake:55:  One space between command "endif" and its parentheses, should be "endif ("  [whitespace/parentheses] [5]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Don Olmstead 2017-09-13 18:23:28 PDT 
Created attachment 320719 [details]
Patch
Comment 4 WebKit Commit Bot 2017-09-13 23:19:12 PDT 
Comment on attachment 320719 [details]
Patch

Clearing flags on attachment: 320719

Committed r222011: <http://trac.webkit.org/changeset/222011>
Comment 5 WebKit Commit Bot 2017-09-13 23:19:13 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-09-27 12:28:03 PDT 
<rdar://problem/34693329>