Bug 176877 - [GTK] Build failure with enchant-2.1.1
Summary: [GTK] Build failure with enchant-2.1.1
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: Other
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-09-13 15:19 PDT by Armin K.
Modified: 2017-09-16 08:01 PDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Armin K. 2017-09-13 15:19:36 PDT
Enchant-2.1.1 was recently released and it removed some deprecated APIs which WebKitGtk is still using. Trying to build WebKitGtk-2.18.0 against Enchant-2.1.1 results in following error:

/home/armin/src/pacman/pkgbuild/webkitgtk/src/webkitgtk-2.18.0/Source/WebCore/platform/text/enchant/TextCheckerEnchant.cpp:132:9: error: use of undeclared identifier 'enchant_dict_free_suggestions'
        enchant_dict_free_suggestions(dictionary, suggestions);

Refer to commit [1] for details.

Easy bug fix (taken from [1]):

sed -i "s#enchant_dict_free_suggestions#enchant_dict_free_string_list#g" Source/WebCore/platform/text/enchant/TextCheckerEnchant.cpp

[1] https://github.com/AbiWord/enchant/commit/744a1a19c1d0a5c3e1359fa994cf60a4d98ee12e
Comment 1 Michael Catanzaro 2017-09-13 20:59:31 PDT
Looks like that API has been around since at least 2005, so it should be no problem to switch.

Really glad that enchant is maintained again.
Comment 2 Michael Catanzaro 2017-09-16 08:01:57 PDT
Committed r222130: <http://trac.webkit.org/changeset/222130>