Bug 176857 - Add WKUIDelegatePrivate equivalent of WKPageUIClient's setIsResizable, getWindowFrame, and setWindowFrame
Summary: Add WKUIDelegatePrivate equivalent of WKPageUIClient's setIsResizable, getWin...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-13 10:41 PDT by Alex Christensen
Modified: 2022-09-07 08:28 PDT (History)
8 users (show)

See Also:


Attachments
Patch (17.73 KB, patch)
2017-09-13 10:43 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (16.70 KB, patch)
2017-09-13 11:36 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2017-09-13 10:41:55 PDT
Add WKUIDelegatePrivate equivalent of WKPageUIClient's setIsResizable, getWindowFrame, and setWindowFrame
Comment 1 Alex Christensen 2017-09-13 10:43:45 PDT
Created attachment 320657 [details]
Patch
Comment 2 Build Bot 2017-09-13 10:45:36 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Tim Horton 2017-09-13 11:13:46 PDT
Comment on attachment 320657 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320657&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:167
> +- (void)_webView:(WKWebView *)webView setIsResizable:(BOOL)isResizable WK_API_AVAILABLE(macosx(WK_MAC_TBA));

This should likely be setResizeable, or possibly a didChange?, or something that someone smarter might suggest. "is" is for getters in Cocoaland.
Comment 4 Alex Christensen 2017-09-13 11:36:31 PDT
Created attachment 320665 [details]
Patch
Comment 5 Alex Christensen 2017-09-13 11:38:25 PDT
http://trac.webkit.org/r221982
Comment 6 Radar WebKit Bug Importer 2017-09-27 12:30:58 PDT
<rdar://problem/34693412>