Bug 176853 - spindumps created on Mac/ios testers are very large
Summary: spindumps created on Mac/ios testers are very large
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Lucas Forschler
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-13 10:28 PDT by Lucas Forschler
Modified: 2022-09-07 08:28 PDT (History)
8 users (show)

See Also:


Attachments
v1 patch for review (3.08 KB, patch)
2017-09-13 10:29 PDT, Lucas Forschler
lforschler: commit-queue-
Details | Formatted Diff | Diff
correct ChangeLog to include the bugzilla entry (3.10 KB, patch)
2017-09-13 10:35 PDT, Lucas Forschler
aakash_jain: review+
lforschler: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Forschler 2017-09-13 10:28:23 PDT
Some Mac and iOS testers include spindumps. These are very large when extracted out to the results folder on build.webkit.org. (multiple terabytes)
We should leave these compressed on disk.

simply pre-compressing them on the client, before we create the results archive would be sufficient.
Comment 1 Lucas Forschler 2017-09-13 10:28:45 PDT
<rdar://problem/34397653>
Comment 2 Lucas Forschler 2017-09-13 10:29:06 PDT
Created attachment 320654 [details]
v1 patch for review
Comment 3 Build Bot 2017-09-13 10:30:43 PDT
Attachment 320654 [details] did not pass style-queue:


ERROR: Tools/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Lucas Forschler 2017-09-13 10:35:03 PDT
Created attachment 320655 [details]
correct ChangeLog to include the bugzilla entry
Comment 5 Aakash Jain 2017-09-13 12:48:59 PDT
Comment on attachment 320655 [details]
correct ChangeLog to include the bugzilla entry

View in context: https://bugs.webkit.org/attachment.cgi?id=320655&action=review

looks good assuming you have tested it.

> Tools/BuildSlaveSupport/test-result-archive:50
> +        shutil.copyfileobj(f_in, f_out)

does this compress the file?
Comment 6 Lucas Forschler 2017-09-13 12:51:28 PDT
Comment on attachment 320655 [details]
correct ChangeLog to include the bugzilla entry

View in context: https://bugs.webkit.org/attachment.cgi?id=320655&action=review

>> Tools/BuildSlaveSupport/test-result-archive:50
>> +        shutil.copyfileobj(f_in, f_out)
> 
> does this compress the file?

Yes... this is straight from the python docs, so it seems to be the standard way of doing it. 
https://docs.python.org/2/library/gzip.html
Comment 7 Lucas Forschler 2017-09-13 12:54:22 PDT
Committed revision 221985.