Bug 176841 - REGRESSION: Fullscreen canvas is not scaled proportionally on Sierra
Summary: REGRESSION: Fullscreen canvas is not scaled proportionally on Sierra
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: WebKit Nightly Build
Hardware: Mac macOS 10.12
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-13 08:30 PDT by aparajita
Modified: 2022-09-07 08:28 PDT (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description aparajita 2017-09-13 08:30:35 PDT 
Summary:

When making an element that contains a canvas fullscreen, the canvas seems to be stretched to fit the screen instead of proportionally filling the screen.


OS: macOS 10.12.6 (16G29)


WebKit version: 12604.1.38.1.6, r221956


Steps to reproduce:

1. Go here: https://www.mapbox.com/mapbox-gl-js/example/fullscreen/

2. Click on the fullscreen control in the upper right corner of the map.


Actual results:

The map is stretched horizontally.


Expected results:

The map maintains its aspect ratio.


Additional info:

This is a regression. Safari 10 and earlier did not have this bug.
Comment 1 Radar WebKit Bug Importer 2017-09-13 13:37:44 PDT 
<rdar://problem/34417841>
Comment 2 Simon Fraser (smfr) 2017-09-13 13:51:10 PDT 
I can't reproduce this on High Sierra with a build of r221956. The fullscreen map is not stretched.
Comment 3 aparajita 2017-09-13 14:25:30 PDT 
I can confirm it works correctly on High Sierra. Any chance it will be fixed on Sierra?
Comment 4 aparajita 2017-09-13 22:33:00 PDT 
Another data point: on my 27" Retina iMac, at any resolution lower than the native resolution (2560 x 1440), the stretching does not occur. At resolutions >= the native resolution, the stretching gets progressively worse.
Comment 5 aparajita 2017-09-14 17:15:24 PDT 
Turns out it has to do with the aspect ratio of the display.

See the comment at 5pm on September 14 at https://bugreport.apple.com/web/?problemID=34410953 for more info.
Comment 6 Simon Fraser (smfr) 2017-09-14 22:24:01 PDT 
rdar://problem/34410953