Bug 176827 – Web Inspector: move Console.addInspectedNode to DOM.setInspectedNode

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

This would allow us to tighten when we send specific information about nodes to the frontend to only for the selected node.

[Devin Rousso]

Created attachment 321116 [details]
Patch

[Build Bot]

Attachment 321116 [details] did not pass style-queue:


ERROR: Source/WebCore/inspector/InspectorDOMAgent.cpp:207:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
Total errors found: 1 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Joseph Pecoraro]

Comment on attachment 321116 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321116&action=review

r=me, very nice!

> Source/WebInspectorUI/UserInterface/Controllers/DOMTreeManager.js:61
> +    get inspectedNode() { return this._inspectedNode; }

Is this actually used? inspectedNode/_inspectedNode other than an early return in `setInspectedNode()`?

Given that `setInspectedNode` doesn't populate it until a callback, I'd expect clients to have a hard time using this, since it would be wrong immediately after someone sets the value. I think we should drop this.

> Source/WebInspectorUI/UserInterface/Controllers/DOMTreeManager.js:537
> +        // COMPATIBILITY (iOS 11): DOM.setInspectedNode did not exist.
> +        if (!DOMAgent.setInspectedNode) {

Well done!

[Devin Rousso]

Created attachment 321777 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 321777 [details]
Patch

Clearing flags on attachment: 321777

Committed r222486: <http://trac.webkit.org/changeset/222486>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/34693354>