Bug 176820 - [WPE] Test fast/dom/Document/CaretRangeFromPoint/replace-element.html fails since r221909
Summary: [WPE] Test fast/dom/Document/CaretRangeFromPoint/replace-element.html fails s...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ms2ger (he/him; ⌚ UTC+1/+2)
URL:
Keywords:
Depends on:
Blocks: 156579
  Show dependency tree / graph
 
Reported: 2017-09-12 17:53 PDT by Carlos Alberto Lopez Perez
Modified: 2022-09-07 08:27 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.48 KB, patch)
2017-11-23 04:36 PST, Ms2ger (he/him; ⌚ UTC+1/+2) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2017-09-12 17:53:34 PDT 
The diff is the following:

--- /home/clopez/webkit/wpe/layout-test-results/fast/dom/Document/CaretRangeFromPoint/replace-element-expected.txt
+++ /home/clopez/webkit/wpe/layout-test-results/fast/dom/Document/CaretRangeFromPoint/replace-element-actual.txt
@@ -1,6 +1,6 @@
 Testing left of the image
 PASS: range.startContainer == image.previousSibling.
-PASS: range.startOffset == 34.
+FAIL: range.startOffset == 35.
 Testing right of the image
 PASS: range.startContainer == image.nextSibling.
 PASS: range.startOffset == 1.


Not sure if this needs a rebaseline (with the FAIL string, ugly), the test needs to be reworked to be less sensive to the offset or it indicates a real failure caused by r221909.
Comment 1 Ms2ger (he/him; ⌚ UTC+1/+2) 2017-11-23 04:36:17 PST 
Created attachment 327495 [details]
Patch
Comment 2 WebKit Commit Bot 2017-11-23 05:09:30 PST 
Comment on attachment 327495 [details]
Patch

Clearing flags on attachment: 327495

Committed r225114: <https://trac.webkit.org/changeset/225114>
Comment 3 WebKit Commit Bot 2017-11-23 05:09:31 PST 
All reviewed patches have been landed.  Closing bug.