Bug 176789 – [GTK][GStreamer] Replaying a webm video twice causes the video to stop getting rendered

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Charlie Turner]

If you visit,

https://bug787579.bugzilla-attachments.gnome.org/attachment.cgi?id=359591

You can do this,
  1) Let the video play out
  2) Click play again, let the video play out
  3) And again
  4) Click play again and you get some junk rendered and then a black screen.

I don't see any GStreamer related error messages.

[Philippe Normand]

I suppose this is happening with gst-gl enabled? Here rendering goes black at 3rd run, not the 4th.

[Philippe Normand]

Created attachment 333294 [details]
workaround

Maybe you can test this patch. It works here by ensuring the video sink has a valid context for every run but ideally I think we should receive the need-context everytime but it's not currently the case. See also https://bugzilla.gnome.org/show_bug.cgi?id=793224

[Philippe Normand]

Created attachment 334143 [details]
Patch

[Xabier Rodríguez Calvar]

Comment on attachment 334143 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334143&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:411
> +GstContext* MediaPlayerPrivateGStreamerBase::requestGLContext(const gchar* contextType)

gchar -> char

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:80
> +    GstContext* requestGLContext(const gchar* contextType);

gchar -> char

[Philippe Normand]

Committed r228641: <https://trac.webkit.org/changeset/228641>