RESOLVED FIXED 176777
Disallow passing null data to uniform1uiv() and friends. 
https://bugs.webkit.org/show_bug.cgi?id=176777
Summary Disallow passing null data to uniform1uiv() and friends.
Ms2ger (he/him; ⌚ UTC+1/+2)
Reported 2017-09-12 05:12:02 PDT
This matches the specification as well as Gecko and Chromium.
Attachments
Patch (7.08 KB, patch)
2017-09-12 05:16 PDT, Ms2ger (he/him; ⌚ UTC+1/+2) 		no flags
DetailsFormatted DiffDiff
Patch (7.09 KB, patch)
2017-09-12 05:25 PDT, Ms2ger (he/him; ⌚ UTC+1/+2) 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews102 for mac-elcapitan (1.35 MB, application/zip)
2017-09-12 06:32 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (1.46 MB, application/zip)
2017-09-12 06:39 PDT, Build Bot 		no flags
Details
Patch (7.09 KB, patch)
2017-09-12 06:42 PDT, Ms2ger (he/him; ⌚ UTC+1/+2) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ms2ger (he/him; ⌚ UTC+1/+2)
Comment 1 2017-09-12 05:16:38 PDT
Created attachment 320534 [details] Patch
Ms2ger (he/him; ⌚ UTC+1/+2)
Comment 2 2017-09-12 05:25:42 PDT
Created attachment 320536 [details] Patch Removed an accidental tab.
Konstantin Tokarev
Comment 3 2017-09-12 05:32:13 PDT
Comment on attachment 320536 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=320536&action=review > LayoutTests/fast/canvas/webgl/webgl2/bindings.html:10 > + window.internals.settings.setWebGL2Enabled(true); AFAIK we use 4-space indentation, though I dunno if that's required in layout tests or not
Adrian Perez
Comment 4 2017-09-12 05:32:44 PDT
Comment on attachment 320536 [details] Patch Informal review r+ Good catch! With this change the functions certainly match the spec as currently available at https://www.khronos.org/registry/webgl/specs/latest/2.0/#3.7
Build Bot
Comment 5 2017-09-12 06:32:46 PDT
Comment on attachment 320536 [details] Patch Attachment 320536 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4523408 New failing tests: fast/canvas/webgl/webgl2/bindings.html
Build Bot
Comment 6 2017-09-12 06:32:47 PDT
Created attachment 320542 [details] Archive of layout-test-results from ews102 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Build Bot
Comment 7 2017-09-12 06:39:19 PDT
Comment on attachment 320536 [details] Patch Attachment 320536 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4523422 New failing tests: fast/canvas/webgl/webgl2/bindings.html
Build Bot
Comment 8 2017-09-12 06:39:21 PDT
Created attachment 320543 [details] Archive of layout-test-results from ews106 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Ms2ger (he/him; ⌚ UTC+1/+2)
Comment 9 2017-09-12 06:42:14 PDT
Created attachment 320544 [details] Patch Fixed paths.
WebKit Commit Bot
Comment 10 2017-09-12 07:55:04 PDT
Comment on attachment 320544 [details] Patch Clearing flags on attachment: 320544 Committed r221915: <http://trac.webkit.org/changeset/221915>
WebKit Commit Bot
Comment 11 2017-09-12 07:55:05 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 12 2017-09-27 12:47:25 PDT
<rdar://problem/34694016>
Note You need to log in before you can comment on or make changes to this bug.