Bug 176776 – innerText getter fails tests for <p> without margin and <h1>-<h6>

• Status: REOPENED
• Component: DOM

[Simon Pieters (:zcorpan)]

See https://github.com/w3c/web-platform-tests/pull/7330

[Ahmad Saleem]

Safari Technical Preview still fail quite a lot of "getter" tests:

https://wpt.fyi/results/html/dom/elements/the-innertext-and-outertext-properties/getter.html?label=master&label=experimental&aligned&view=subtest&q=innertext

Just wanted to update. Thanks!

[Radar WebKit Bug Importer]

<rdar://problem/98459918>

[Ahmad Saleem]

*** Bug 273219 has been marked as a duplicate of this bug. ***

[Ahmad Saleem]

Let's give it a try - PR - https://github.com/WebKit/WebKit/pull/27835 (Still in Draft - might need to rebaseline bunch of tests).

[Ahmad Saleem]

Created attachment 471306 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 471306 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=471306&action=review

> Source/WebCore/editing/TextIterator.cpp:928
> +    if (RefPtr element = dynamicDowncast<HTMLElement>(node))

Why not just:
return node->hasTagName(pTag);

[Ahmad Saleem]

Created attachment 471312 [details]
Patch

[Ahmad Saleem]

(In reply to Ryosuke Niwa from comment #6)
> Comment on attachment 471306 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=471306&action=review
> 
> > Source/WebCore/editing/TextIterator.cpp:928
> > +    if (RefPtr element = dynamicDowncast<HTMLElement>(node))
> 
> Why not just:
> return node->hasTagName(pTag);

Done and did this:

return node.hasTagName(pTag);

Adding `->` was giving error and this is first time doing via bugzilla, it removed your r+. :-(

[Ahmad Saleem]

Created attachment 471316 [details]
Patch

[Ahmad Saleem]

Marking this as 'RESOLVED FIXED' since this landed.

Commit: https://github.com/WebKit/WebKit/commit/2eee050cf9ac6cface6d3cab4355a4ab42998dc5

Closing my GitHub PR as well - which is 1-1 same as this attached patch and passing all EWS results.

PR - https://github.com/WebKit/WebKit/pull/27835

[Aditya Keerthi]

Re-opening, as this was reverted in https://commits.webkit.org/278785@main