Bug 176767 - REGRESSION (r221272): WKWebView gets stuck zoomed in if the web process crashes
Summary: REGRESSION (r221272): WKWebView gets stuck zoomed in if the web process crashes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-11 22:58 PDT by Tim Horton
Modified: 2017-09-27 12:36 PDT (History)
10 users (show)

See Also:

Attachments
Patch (4.26 KB, patch)
2017-09-11 22:58 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (8.08 KB, patch)
2017-09-11 23:09 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2017-09-11 22:58:19 PDT 
REGRESSION (r221272): WKWebView gets stuck zoomed in if the web process crashes
Comment 1 Tim Horton 2017-09-11 22:58:39 PDT 
Created attachment 320521 [details]
Patch
Comment 2 mitz 2017-09-11 23:03:28 PDT 
Comment on attachment 320521 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320521&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:228
> +    [webView loadHTMLString:@"<head><meta name='viewport' content='initial-scale=1' /></head>" baseURL:nil];

No need for the / and the preceding space in the meta tag.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:231
> +    RetainPtr<UIWindow> window = adoptNS([[UIWindow alloc] initWithFrame:CGRectMake(0, 0, 800, 600)]);

auto?

> Tools/TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:236
> +    [webView loadHTMLString:@"<head><meta name='viewport' content='initial-scale=1' /></head>" baseURL:nil];

“ /”
Comment 3 Tim Horton 2017-09-11 23:07:31 PDT 
Since literally all of those things were copied from the tests above, I fixed the whole file.
Comment 4 Tim Horton 2017-09-11 23:09:00 PDT 
Created attachment 320522 [details]
Patch
Comment 5 WebKit Commit Bot 2017-09-11 23:51:54 PDT 
Comment on attachment 320522 [details]
Patch

Clearing flags on attachment: 320522

Committed r221906: <http://trac.webkit.org/changeset/221906>
Comment 6 WebKit Commit Bot 2017-09-11 23:51:55 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-09-27 12:36:03 PDT 
<rdar://problem/34693573>