Bug 176740 – [Cleanup] Follow up cleanup for DOMFormData implementation

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sam Weinig]

[Cleanup] Follow up cleanup for DOMFormData implementation

[Sam Weinig]

Created attachment 320513 [details]
Patch

[Build Bot]

Attachment 320513 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/network/FormData.cpp:251:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 1 in 42 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Sam Weinig]

DOMFormData unfortunately needs to maintain its TextEncoding member, as it is used by HiddenInputType::appendFormData(...).

[Sam Weinig]

Created attachment 320514 [details]
Patch

[Alex Christensen]

Comment on attachment 320514 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320514&action=review

> Source/WTF/wtf/KeyValuePair.h:56
> +    KeyType key;
> +    ValueType value { };

Do we intentionally want to keep no default initializer list for key?

[Sam Weinig]

(In reply to Alex Christensen from comment #5)
> Comment on attachment 320514 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=320514&action=review
> 
> > Source/WTF/wtf/KeyValuePair.h:56
> > +    KeyType key;
> > +    ValueType value { };
> 
> Do we intentionally want to keep no default initializer list for key?

I found this really odd, but didn’t want to change it in this patch.

[WebKit Commit Bot]

Comment on attachment 320514 [details]
Patch

Clearing flags on attachment: 320514

Committed r221914: <http://trac.webkit.org/changeset/221914>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/34693683>