Bug 176736 – [iOS WK2] ExternalSourceDataTransferItemGetAsEntry tests produce inconsistent results on test automation bots

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Wenson Hsieh]

These tests are failing on the bots, since the order in which files are read and appear is different from the order observed locally on my machine. Instead, these tests should be tweaked so they don't spit out FileSystemEntry output in arbitrary order.

[Wenson Hsieh]

Created attachment 320479 [details]
Patch

[Megan Gardner]

Comment on attachment 320479 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320479&action=review

Good fix, just make sure that what you're testing against is also guaranteed to be in alphabetical order. then r=me. Not sure if you need a WK2 review as well.

> Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm:966
>      ];

I don't see that this list is sorted again in code. Can you either do that and/or make a comment that these are expected to be in alphabetical order?

[Wenson Hsieh]

Comment on attachment 320479 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320479&action=review

>> Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm:966
>>      ];
> 
> I don't see that this list is sorted again in code. Can you either do that and/or make a comment that these are expected to be in alphabetical order?

I don't think sorting this test expectation is really needed, since it's hard-coded anyways to be in alphabetical order...I'll add a comment to make this more apparent, though.

[Wenson Hsieh]

Created attachment 320493 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 320493 [details]
Patch for landing

Clearing flags on attachment: 320493

Committed r221893: <http://trac.webkit.org/changeset/221893>

[Radar WebKit Bug Importer]

<rdar://problem/34694490>