Bug 176728 - Add WKUIDelegatePrivate equivalent of WKPageUIClient's runModal
Summary: Add WKUIDelegatePrivate equivalent of WKPageUIClient's runModal
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-11 13:36 PDT by Alex Christensen
Modified: 2017-09-27 13:01 PDT (History)
7 users (show)

See Also:

Attachments
Patch (10.14 KB, patch)
2017-09-11 13:41 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (10.14 KB, patch)
2017-09-12 00:19 PDT, Alex Christensen 		thorton: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2017-09-11 13:36:28 PDT 
Add WKUIDelegatePrivate equivalent of WKPageUIClient's runModal
Comment 1 Alex Christensen 2017-09-11 13:41:51 PDT 
Created attachment 320466 [details]
Patch
Comment 2 Build Bot 2017-09-11 13:43:25 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Alex Christensen 2017-09-12 00:19:08 PDT 
Created attachment 320526 [details]
Patch
Comment 4 Tim Horton 2017-09-12 09:29:07 PDT 
Comment on attachment 320526 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320526&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:157
> +- (void)_webViewRunModal:(WKWebView *)webView WK_API_AVAILABLE(macosx(WK_MAC_TBA));

As mentioned on IRC, I think we can do better with this name.
Comment 5 Alex Christensen 2017-09-12 09:35:43 PDT 
It's just SPI.  I think I'm going to keep the name as it is.  We should remove it eventually once we've implemented the dialog element.  See https://bugs.webkit.org/show_bug.cgi?id=151885
Comment 6 Alex Christensen 2017-09-12 09:37:25 PDT 
http://trac.webkit.org/r221922
Comment 7 Tim Horton 2017-09-12 09:42:20 PDT 
(In reply to Alex Christensen from comment #5)
> It's just SPI.  I think I'm going to keep the name as it is.

You know how I feel about that excuse :P

> We should remove it eventually once we've implemented the dialog element.  See
> https://bugs.webkit.org/show_bug.cgi?id=151885

Fair.
Comment 8 Alex Christensen 2017-09-12 09:42:53 PDT 
http://trac.webkit.org/r221923
Comment 9 Radar WebKit Bug Importer 2017-09-27 13:01:27 PDT 
<rdar://problem/34694493>