Add WKUIDelegatePrivate equivalent of WKPageUIClient's runModal
Created attachment 320466 [details]
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Created attachment 320526 [details]
Comment on attachment 320526 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=320526&action=review
> +- (void)_webViewRunModal:(WKWebView *)webView WK_API_AVAILABLE(macosx(WK_MAC_TBA));
As mentioned on IRC, I think we can do better with this name.
It's just SPI. I think I'm going to keep the name as it is. We should remove it eventually once we've implemented the dialog element. See https://bugs.webkit.org/show_bug.cgi?id=151885
(In reply to Alex Christensen from comment #5)
> It's just SPI. I think I'm going to keep the name as it is.
You know how I feel about that excuse :P
> We should remove it eventually once we've implemented the dialog element. See