RESOLVED FIXED 176728
Add WKUIDelegatePrivate equivalent of WKPageUIClient's runModal 
https://bugs.webkit.org/show_bug.cgi?id=176728
Summary Add WKUIDelegatePrivate equivalent of WKPageUIClient's runModal
Alex Christensen
Reported 2017-09-11 13:36:28 PDT
Add WKUIDelegatePrivate equivalent of WKPageUIClient's runModal
Attachments
Patch (10.14 KB, patch)
2017-09-11 13:41 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (10.14 KB, patch)
2017-09-12 00:19 PDT, Alex Christensen 		thorton: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2017-09-11 13:41:51 PDT
Created attachment 320466 [details] Patch
Build Bot
Comment 2 2017-09-11 13:43:25 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Alex Christensen
Comment 3 2017-09-12 00:19:08 PDT
Created attachment 320526 [details] Patch
Tim Horton
Comment 4 2017-09-12 09:29:07 PDT
Comment on attachment 320526 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=320526&action=review > Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:157 > +- (void)_webViewRunModal:(WKWebView *)webView WK_API_AVAILABLE(macosx(WK_MAC_TBA)); As mentioned on IRC, I think we can do better with this name.
Alex Christensen
Comment 5 2017-09-12 09:35:43 PDT
It's just SPI. I think I'm going to keep the name as it is. We should remove it eventually once we've implemented the dialog element. See https://bugs.webkit.org/show_bug.cgi?id=151885
Alex Christensen
Comment 6 2017-09-12 09:37:25 PDT
http://trac.webkit.org/r221922
Tim Horton
Comment 7 2017-09-12 09:42:20 PDT
(In reply to Alex Christensen from comment #5) > It's just SPI. I think I'm going to keep the name as it is. You know how I feel about that excuse :P > We should remove it eventually once we've implemented the dialog element. See > https://bugs.webkit.org/show_bug.cgi?id=151885 Fair.
Alex Christensen
Comment 8 2017-09-12 09:42:53 PDT
http://trac.webkit.org/r221923
Radar WebKit Bug Importer
Comment 9 2017-09-27 13:01:27 PDT
<rdar://problem/34694493>
Note You need to log in before you can comment on or make changes to this bug.