Bug 176711 - [CMake] Link InjectedBundle tests to gtest
Summary: [CMake] Link InjectedBundle tests to gtest
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-09-11 10:46 PDT by Michael Catanzaro
Modified: 2017-09-11 10:59 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.12 KB, patch)
2017-09-11 10:54 PDT, Michael Catanzaro
mcatanzaro: review-
mcatanzaro: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2017-09-11 10:46:24 PDT
I get this warning when trying to run any cross-platform InjectedBundle test locally:

** (WebKitWebProcess:7446): WARNING **: Error loading the injected bundle (/home/mcatanzaro/Projects/WebKit/Tools/gtk/../../WebKitBuild/GNOME/lib/libTestWebKitAPIInjectedBundle.so): /home/mcatanzaro/Projects/WebKit/Tools/gtk/../../WebKitBuild/GNOME/lib/libTestWebKitAPIInjectedBundle.so: undefined symbol: _ZN7testing8internal30GetBoolAssertionFailureMessageERKNS_15AssertionResultEPKcS5_S5_

It's because libTestWebKitAPIInjectedBundle.so is not linked to gtest. I have no clue how it works on the bots.
Comment 1 Michael Catanzaro 2017-09-11 10:54:30 PDT
Created attachment 320445 [details]
Patch
Comment 2 Michael Catanzaro 2017-09-11 10:57:38 PDT
Comment on attachment 320445 [details]
Patch

That's because it's not supposed to be used from InjectedBundle
Comment 3 Michael Catanzaro 2017-09-11 10:59:04 PDT
And it was happening only for me because I had local modifications to try to use it.