Bug 176710 - AX: Fields that are autofill-able but don't have an AutoFill button should still be announced as autofill-able
Summary: AX: Fields that are autofill-able but don't have an AutoFill button should st...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: Safari 10
Hardware: All All
: P2 Enhancement
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-11 10:29 PDT by Maureen Daum
Modified: 2017-09-14 00:01 PDT (History)
5 users (show)

See Also:

Attachments
Patch (11.09 KB, patch)
2017-09-11 10:43 PDT, Maureen Daum 		no flags Details | Formatted Diff | Diff
Patch with test (22.62 KB, patch)
2017-09-12 17:28 PDT, Maureen Daum 		no flags Details | Formatted Diff | Diff
Patch with test (22.66 KB, patch)
2017-09-13 11:26 PDT, Maureen Daum 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Maureen Daum 2017-09-11 10:29:15 PDT 
AX: Fields that are autofill-able but don't have an AutoFill button should still be announced as autofill-able. Currently VO only announces that fields have AutoFill available if there is an AutoFill button in the field. However, there are fields where AutoFill is available but we choose not to show the AutoFill button in them. There should be some way to mark these fields that don't have an AutoFill button as being autofill-able so that VO can announce it.
Comment 1 Radar WebKit Bug Importer 2017-09-11 10:29:39 PDT 
<rdar://problem/34369917>
Comment 2 Maureen Daum 2017-09-11 10:43:10 PDT 
Created attachment 320441 [details]
Patch
Comment 3 Alex Christensen 2017-09-11 10:52:48 PDT 
Comment on attachment 320441 [details]
Patch

Please add a test.  https://bugs.webkit.org/show_bug.cgi?id=176139 added a test for autofill stuff in the bundle.
Comment 4 chris fleizach 2017-09-11 11:04:13 PDT 
Comment on attachment 320441 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320441&action=review

> Source/WebCore/ChangeLog:12
> +        * accessibility/AccessibilityObject.cpp:

can you add a test? thanks

> Source/WebCore/accessibility/AccessibilityObject.cpp:2464
> +    return downcast<HTMLInputElement>(*node).isAutoFillAvailable() || downcast<HTMLInputElement>(*node).autoFillButtonType() != AutoFillButtonType::None;

will isAutoFillAvailable() always be true if button type == None?

how will users activate auto fill if there's no button to press?
Comment 5 Maureen Daum 2017-09-11 11:13:33 PDT 
Comment on attachment 320441 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320441&action=review

>> Source/WebCore/ChangeLog:12
>> +        * accessibility/AccessibilityObject.cpp:
> 
> can you add a test? thanks

Sure thing!

>> Source/WebCore/accessibility/AccessibilityObject.cpp:2464
>> +    return downcast<HTMLInputElement>(*node).isAutoFillAvailable() || downcast<HTMLInputElement>(*node).autoFillButtonType() != AutoFillButtonType::None;
> 
> will isAutoFillAvailable() always be true if button type == None?
> 
> how will users activate auto fill if there's no button to press?

isAutoFillAvailable() will only be true on the text fields that Safari sets it on. Users can use the arrow keys to activate autofill. The VoiceOver announcement specifies, "To open the autofill menu, press the up or down arrow key, then press the return key to enter it into the form."
Comment 6 Maureen Daum 2017-09-12 17:28:25 PDT 
Created attachment 320587 [details]
Patch with test
Comment 7 Maureen Daum 2017-09-13 11:26:23 PDT 
Created attachment 320662 [details]
Patch with test
Comment 8 WebKit Commit Bot 2017-09-14 00:01:24 PDT 
Comment on attachment 320662 [details]
Patch with test

Clearing flags on attachment: 320662

Committed r222013: <http://trac.webkit.org/changeset/222013>
Comment 9 WebKit Commit Bot 2017-09-14 00:01:26 PDT 
All reviewed patches have been landed.  Closing bug.