AX: Fields that are autofill-able but don't have an AutoFill button should still be announced as autofill-able. Currently VO only announces that fields have AutoFill available if there is an AutoFill button in the field. However, there are fields where AutoFill is available but we choose not to show the AutoFill button in them. There should be some way to mark these fields that don't have an AutoFill button as being autofill-able so that VO can announce it.
<rdar://problem/34369917>
Created attachment 320441 [details] Patch
Comment on attachment 320441 [details] Patch Please add a test. https://bugs.webkit.org/show_bug.cgi?id=176139 added a test for autofill stuff in the bundle.
Comment on attachment 320441 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=320441&action=review > Source/WebCore/ChangeLog:12 > + * accessibility/AccessibilityObject.cpp: can you add a test? thanks > Source/WebCore/accessibility/AccessibilityObject.cpp:2464 > + return downcast<HTMLInputElement>(*node).isAutoFillAvailable() || downcast<HTMLInputElement>(*node).autoFillButtonType() != AutoFillButtonType::None; will isAutoFillAvailable() always be true if button type == None? how will users activate auto fill if there's no button to press?
Comment on attachment 320441 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=320441&action=review >> Source/WebCore/ChangeLog:12 >> + * accessibility/AccessibilityObject.cpp: > > can you add a test? thanks Sure thing! >> Source/WebCore/accessibility/AccessibilityObject.cpp:2464 >> + return downcast<HTMLInputElement>(*node).isAutoFillAvailable() || downcast<HTMLInputElement>(*node).autoFillButtonType() != AutoFillButtonType::None; > > will isAutoFillAvailable() always be true if button type == None? > > how will users activate auto fill if there's no button to press? isAutoFillAvailable() will only be true on the text fields that Safari sets it on. Users can use the arrow keys to activate autofill. The VoiceOver announcement specifies, "To open the autofill menu, press the up or down arrow key, then press the return key to enter it into the form."
Created attachment 320587 [details] Patch with test
Created attachment 320662 [details] Patch with test
Comment on attachment 320662 [details] Patch with test Clearing flags on attachment: 320662 Committed r222013: <http://trac.webkit.org/changeset/222013>
All reviewed patches have been landed. Closing bug.