Bug 176688 - [css-grid] Use transferred size over content size for automatic minimum size
Summary: [css-grid] Use transferred size over content size for automatic minimum size
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Manuel Rego Casasnovas
URL:
Keywords: BlinkMergeCandidate, InRadar
Depends on:
Blocks: 60731
  Show dependency tree / graph
 
Reported: 2017-09-11 05:59 PDT by Manuel Rego Casasnovas
Modified: 2017-09-27 12:32 PDT (History)
7 users (show)

See Also:

Attachments
Patch (17.39 KB, patch)
2017-09-11 06:05 PDT, Manuel Rego Casasnovas 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Rego Casasnovas 2017-09-11 05:59:17 PDT 
CSS WG has agreed to modify the spec so now the transferred size is used
(if it exists) independently if it's bigger or smaller
than the content size.
See: https://github.com/w3c/csswg-drafts/issues/1149

The spec text (https://drafts.csswg.org/css-grid/#min-size-auto):
  "The automatic minimum size for a grid item in a given dimension is
   its specified size if it exists, otherwise its transferred size
   if that exists, else its content size"
Comment 1 Manuel Rego Casasnovas 2017-09-11 06:05:05 PDT 
Created attachment 320427 [details]
Patch
Comment 2 Javier Fernandez 2017-09-11 06:16:35 PDT 
Comment on attachment 320427 [details]
Patch

The patch looks good to me, regarding grid's logic changes.
Comment 3 Sergio Villar Senin 2017-09-12 03:31:22 PDT 
Comment on attachment 320427 [details]
Patch

Really happy to see that code being deleted.
Comment 4 WebKit Commit Bot 2017-09-12 04:30:52 PDT 
Comment on attachment 320427 [details]
Patch

Clearing flags on attachment: 320427

Committed r221910: <http://trac.webkit.org/changeset/221910>
Comment 5 WebKit Commit Bot 2017-09-12 04:30:54 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-09-27 12:32:34 PDT 
<rdar://problem/34693453>