Bug 176683 - Remove unnecessary virtual keyword from JS test files
Summary: Remove unnecessary virtual keyword from JS test files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Frédéric Wang (:fredw)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-11 00:02 PDT by Frédéric Wang (:fredw)
Modified: 2017-09-27 12:42 PDT (History)
5 users (show)

See Also:

Attachments
Patch (10.46 KB, patch)
2017-09-11 00:04 PDT, Frédéric Wang (:fredw) 		no flags Details | Formatted Diff | Diff
Patch (12.08 KB, patch)
2017-09-11 01:25 PDT, Frédéric Wang (:fredw) 		simon.fraser: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Frédéric Wang (:fredw) 2017-09-11 00:02:02 PDT 
Remove unnecessary virtual keyword from JS test files
Comment 1 Frédéric Wang (:fredw) 2017-09-11 00:04:46 PDT 
Created attachment 320418 [details]
Patch
Comment 2 Build Bot 2017-09-11 00:07:59 PDT 
Comment on attachment 320418 [details]
Patch

Attachment 320418 [details] did not pass bindings-ews (mac):
Output: http://webkit-queues.webkit.org/results/4509987

New failing tests:
(JS) JSTestCallbackFunction.h
(JS) JSTestCallbackFunctionRethrow.h
(JS) JSTestCallbackFunctionWithThisObject.h
(JS) JSTestCallbackFunctionWithTypedefs.h
(JS) JSTestCallbackInterface.h
(JS) JSTestVoidCallbackFunction.h
Comment 3 Frédéric Wang (:fredw) 2017-09-11 01:25:03 PDT 
Created attachment 320420 [details]
Patch
Comment 4 Frédéric Wang (:fredw) 2017-09-12 00:37:03 PDT 
Committed r221908: <http://trac.webkit.org/changeset/221908>
Comment 5 Radar WebKit Bug Importer 2017-09-27 12:42:58 PDT 
<rdar://problem/34693817>